Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: chrome/browser/resources/settings/appearance_page/appearance_page.html

Issue 1349543006: [MD settings] adding homepage url input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@appearance7b
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 <link rel="import" href="chrome://md-settings/checkbox/checkbox.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/pape r-radio-button.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/pape r-radio-button.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-group/paper -radio-group.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-group/paper -radio-group.html">
6 <link rel="import" href="chrome://md-settings/checkbox/checkbox.html">
6 7
7 <dom-module id="cr-settings-appearance-page"> 8 <dom-module id="cr-settings-appearance-page">
8 <link rel="import" type="css" 9 <link rel="import" type="css"
9 href="chrome://md-settings/settings_page/settings_page.css"> 10 href="chrome://md-settings/settings_page/settings_page.css">
10 <link rel="import" type="css" 11 <link rel="import" type="css"
11 href="chrome://md-settings/appearance_page/appearance_page.css"> 12 href="chrome://md-settings/appearance_page/appearance_page.css">
12 <link rel="import" type="css" href="chrome://resources/css/widgets.css"> 13 <link rel="import" type="css" href="chrome://resources/css/widgets.css">
13 <link rel="import" href="chrome://resources/html/action_link.html"> 14 <link rel="import" href="chrome://resources/html/action_link.html">
14 <template> 15 <template>
15 <div id="action-container"> 16 <div id="action-container">
(...skipping 11 matching lines...) Expand all
27 </cr-settings-checkbox> 28 </cr-settings-checkbox>
28 <template is="dom-if" if="{{prefs.browser.show_home_button.value}}"> 29 <template is="dom-if" if="{{prefs.browser.show_home_button.value}}">
29 <div class="radio-container"> 30 <div class="radio-container">
30 <paper-radio-group 31 <paper-radio-group
31 selected="{{isNewTabPageString_}}"> 32 selected="{{isNewTabPageString_}}">
32 <paper-radio-button 33 <paper-radio-button
33 name="true">[[i18n_.homePageNtp]]</paper-radio-button> 34 name="true">[[i18n_.homePageNtp]]</paper-radio-button>
34 <paper-radio-button 35 <paper-radio-button
35 name="false">[[i18n_.openThisPage]]</paper-radio-button> 36 name="false">[[i18n_.openThisPage]]</paper-radio-button>
36 </paper-radio-group> 37 </paper-radio-group>
38 <div class="radio-extended">
39 <paper-input no-label-float
40 value="{{homepage_}}"
Dan Beam 2015/09/17 17:13:48 why can't this just be: value="{{prefs.homepage.va
dschuyler 2015/09/17 18:02:41 We can do that :) This next patch uses prefs.home
dschuyler 2015/09/17 18:28:36 Also, there's a DCHECK about the url being valid t
41 label="[[i18n_.onStartupEnterUrl]]">
42 </paper-input>
Dan Beam 2015/09/17 17:13:48 this can be 2 lines instead of 4
dschuyler 2015/09/17 18:02:41 Done.
43 <paper-button
44 on-tap="onSetHomepageTap_">[[i18n_.changeHomePage]]</paper-button>
45 </div>
37 </div> 46 </div>
38 </template> 47 </template>
39 <cr-settings-checkbox pref="{{prefs.bookmark_bar.show_on_all_tabs}}" 48 <cr-settings-checkbox pref="{{prefs.bookmark_bar.show_on_all_tabs}}"
40 i18n-values="label:showBookmarksBar"> 49 i18n-values="label:showBookmarksBar">
41 </cr-settings-checkbox> 50 </cr-settings-checkbox>
42 </template> 51 </template>
43 <script src="appearance_page.js"></script> 52 <script src="appearance_page.js"></script>
44 </dom-module> 53 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698