[MD settings] adding homepage url input

[MD settings] adding homepage url input

This CL added an input and button for setting a
custom (i.e. non-NewTabPage) homepage.

BUG=531786
Committed: https://crrev.com/dbe2b10da8276035d1ff18c04103cf09b26a7eb6
Cr-Commit-Position: refs/heads/master@{#350348}

[dschuyler, 2015-09-17 04:45:13]

dschuyler@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Dan Beam, 2015-09-17 17:13:48]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-09-17 17:13:49]

https://codereview.chromium.org/1349543006/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/1349543006/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.html:40:
value="{{homepage_}}"
why can't this just be: value="{{prefs.homepage.value}}" and remove homepage_?

https://codereview.chromium.org/1349543006/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.html:42:
</paper-input>
this can be 2 lines instead of 4

[dschuyler, 2015-09-17 18:02:41]

https://codereview.chromium.org/1349543006/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/1349543006/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.html:40:
value="{{homepage_}}"
On 2015/09/17 17:13:48, Dan Beam wrote:
> why can't this just be: value="{{prefs.homepage.value}}" and remove homepage_?

We can do that :)  This next patch uses prefs.homepage.value
directly.  Now edits are done immediately.
So there's no more need for a 'submit this change' button (since
changes happen directly).

Done.

https://codereview.chromium.org/1349543006/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.html:42:
</paper-input>
On 2015/09/17 17:13:48, Dan Beam wrote:
> this can be 2 lines instead of 4

Done.

[dschuyler, 2015-09-17 18:28:36]

https://codereview.chromium.org/1349543006/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/1349543006/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.html:40:
value="{{homepage_}}"
On 2015/09/17 18:02:41, dschuyler wrote:
> On 2015/09/17 17:13:48, Dan Beam wrote:
> > why can't this just be: value="{{prefs.homepage.value}}" and remove
homepage_?
> 
> We can do that :)  This next patch uses prefs.homepage.value
> directly.  Now edits are done immediately.
> So there's no more need for a 'submit this change' button (since
> changes happen directly).
> 
> Done.

Also, there's a DCHECK about the url being valid that I'd
need to look into further.  Since the url is being interactively
created, it may be temporarily invalid while editing.

[stevenjb, 2015-09-18 22:33:49]

lgtm

[dschuyler, 2015-09-21 21:53:11]

Added crbug 534599 to track the topic of prefs values (such as the homepage)
being updated while the user is editing the value.  (i.e. this CL has a known
issue with that crbug)

[Dan Beam, 2015-09-21 23:28:32]

lgtm w/that followup

[dschuyler, 2015-09-22 18:44:27]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2015-09-22 18:47:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1349543006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1349543006/20001

[commit-bot: I haz the power, 2015-09-22 18:51:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 18:51:25]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dschuyler, 2015-09-23 17:33:28]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2015-09-23 17:33:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1349543006/#ps60001
(title: "merge with master")

[commit-bot: I haz the power, 2015-09-23 17:36:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1349543006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1349543006/60001

[commit-bot: I haz the power, 2015-09-23 18:30:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-23 18:36:04]

Patchset 4 (id:??) landed as
https://crrev.com/dbe2b10da8276035d1ff18c04103cf09b26a7eb6
Cr-Commit-Position: refs/heads/master@{#350348}