Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1349163002: Revert of [test] Fix cctest path separators on Windows (Closed)

Created:
5 years, 3 months ago by Jakob Kummerow
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com, domenic
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [test] Fix cctest path separators on Windows (patchset #2 id:20001 of https://codereview.chromium.org/1348653003/ ) Reason for revert: mozilla tests are failing on Windows Original issue's description: > [test] Fix cctest path separators on Windows > > Now run-tests.py understands "suite/foo/bar" with forward slashes for > command-line test selection on all test suites on all platforms. > > Previously, file-based suites like mjsunit also accepted "mjsunit/foo\bar"; > that behavior is sacrificed here in favor of unification. For the cctest > suite, OTOH, it wasn't possible on Windows to select specific tests at all. > > Committed: https://crrev.com/b36cfdb39ae648b49a1396c4f669df9b1f57996c > Cr-Commit-Position: refs/heads/master@{#30794} TBR=machenbach@google.com,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5f44a9105980e7ca3a444c9c4293ee9442a8139f Cr-Commit-Position: refs/heads/master@{#30795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M test/intl/testcfg.py View 1 chunk +1 line, -3 lines 0 comments Download
M test/message/testcfg.py View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/testcfg.py View 1 chunk +1 line, -3 lines 0 comments Download
M test/mozilla/testcfg.py View 1 chunk +2 lines, -3 lines 0 comments Download
M test/test262-es6/testcfg.py View 1 chunk +2 lines, -3 lines 0 comments Download
M test/test262/testcfg.py View 1 chunk +2 lines, -3 lines 0 comments Download
M test/webkit/testcfg.py View 1 chunk +1 line, -3 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Jakob Kummerow
Created Revert of [test] Fix cctest path separators on Windows
5 years, 3 months ago (2015-09-17 11:59:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349163002/1
5 years, 3 months ago (2015-09-17 12:00:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 12:00:18 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5f44a9105980e7ca3a444c9c4293ee9442a8139f Cr-Commit-Position: refs/heads/master@{#30795}
5 years, 3 months ago (2015-09-17 12:00:33 UTC) #4
Jakob Kummerow
5 years, 3 months ago (2015-09-17 12:44:56 UTC) #5
Message was sent while issue was closed.
Reland: https://codereview.chromium.org/1356613002

Powered by Google App Engine
This is Rietveld 408576698