Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1349093005: base: remove AsyncSocketIoHandler (Closed)

Created:
5 years, 3 months ago by Elly Fong-Jones
Modified:
5 years, 3 months ago
Reviewers:
danakj, Nico
CC:
chromium-reviews, qsr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: remove AsyncSocketIoHandler This code was added a couple of years ago in this CL: https://chromiumcodereview.appspot.com/23137015 but was never actually used. TEST=base_unittests BUG= Committed: https://crrev.com/0b62ba881585585804dda84371d5773312ae89c5 Cr-Commit-Position: refs/heads/master@{#350199}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -468 lines) Patch
M base/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
D base/async_socket_io_handler.h View 1 chunk +0 lines, -110 lines 0 comments Download
D base/async_socket_io_handler_posix.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D base/async_socket_io_handler_unittest.cc View 1 chunk +0 lines, -171 lines 0 comments Download
D base/async_socket_io_handler_win.cc View 1 chunk +0 lines, -77 lines 0 comments Download
M base/base.gyp View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Elly Fong-Jones
danakj: PTAL?
5 years, 3 months ago (2015-09-22 16:37:38 UTC) #2
Nico
lgtm
5 years, 3 months ago (2015-09-22 17:11:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349093005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349093005/1
5 years, 3 months ago (2015-09-22 17:13:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 18:31:44 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 18:44:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b62ba881585585804dda84371d5773312ae89c5
Cr-Commit-Position: refs/heads/master@{#350199}

Powered by Google App Engine
This is Rietveld 408576698