Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1348973004: Merge SVGFilter into Filter (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), gyuyoung2, jbroman, jchaffraix+rendering, Justin Novosad, kouhei+svg_chromium.org, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Merge SVGFilter into Filter This brings the handling for bbox-relative coordinates into the base class and drops the empty shell that remains. BUG=109224 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202465

Patch Set 1 #

Total comments: 5

Patch Set 2 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -136 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceFilter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/SVGFilterPainter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
D Source/core/svg/graphics/filters/SVGFilter.h View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/core/svg/graphics/filters/SVGFilter.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
M Source/platform/graphics/filters/Filter.h View 1 2 chunks +15 lines, -17 lines 0 comments Download
M Source/platform/graphics/filters/Filter.cpp View 1 3 chunks +35 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
fs
5 years, 3 months ago (2015-09-17 14:41:11 UTC) #2
f(malita)
https://codereview.chromium.org/1348973004/diff/1/Source/platform/graphics/filters/Filter.h File Source/platform/graphics/filters/Filter.h (right): https://codereview.chromium.org/1348973004/diff/1/Source/platform/graphics/filters/Filter.h#newcode68 Source/platform/graphics/filters/Filter.h:68: protected: Nit: Filter is now final, protected -> private. ...
5 years, 3 months ago (2015-09-17 15:18:06 UTC) #3
Stephen White
Great stuff! https://codereview.chromium.org/1348973004/diff/1/Source/platform/graphics/filters/Filter.h File Source/platform/graphics/filters/Filter.h (right): https://codereview.chromium.org/1348973004/diff/1/Source/platform/graphics/filters/Filter.h#newcode75 Source/platform/graphics/filters/Filter.h:75: bool m_bboxMode; On 2015/09/17 15:18:05, f(malita) wrote: ...
5 years, 3 months ago (2015-09-17 16:19:58 UTC) #4
fs
https://codereview.chromium.org/1348973004/diff/1/Source/platform/graphics/filters/Filter.h File Source/platform/graphics/filters/Filter.h (right): https://codereview.chromium.org/1348973004/diff/1/Source/platform/graphics/filters/Filter.h#newcode68 Source/platform/graphics/filters/Filter.h:68: protected: On 2015/09/17 at 15:18:06, f(malita) wrote: > Nit: ...
5 years, 3 months ago (2015-09-17 16:22:32 UTC) #5
f(malita)
Thanks, LGTM!
5 years, 3 months ago (2015-09-17 16:24:40 UTC) #6
Stephen White
LGTM too
5 years, 3 months ago (2015-09-17 16:25:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348973004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348973004/20001
5 years, 3 months ago (2015-09-17 19:19:50 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 19:56:01 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202465

Powered by Google App Engine
This is Rietveld 408576698