Source/core/layout/svg/SVGLayoutTreeAsText.cpp - Issue 1348973004: Merge SVGFilter into Filter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/svg/SVGLayoutTreeAsText.cpp

Issue 1348973004: Merge SVGFilter into Filter (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Nits. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/svg/SVGLayoutTreeAsText.cpp

diff --git a/Source/core/layout/svg/SVGLayoutTreeAsText.cpp b/Source/core/layout/svg/SVGLayoutTreeAsText.cpp

index f85e8c24567e4f3ae7cf99c74fc9ea362afff169..ab75e070c10a43e225b423b03d53bbf8b84e7f15 100644

--- a/Source/core/layout/svg/SVGLayoutTreeAsText.cpp

+++ b/Source/core/layout/svg/SVGLayoutTreeAsText.cpp

@@ -510,7 +510,7 @@ void writeSVGResourceContainer(TextStream& ts, const LayoutObject& object, int i

ts << "\n";

// Creating a placeholder filter which is passed to the builder.

FloatRect dummyRect;

- RefPtrWillBeRawPtr<SVGFilter> dummyFilter = SVGFilter::create(dummyRect, dummyRect, true);

+ RefPtrWillBeRawPtr<Filter> dummyFilter = Filter::create(dummyRect, dummyRect, 1, Filter::BoundingBox);

if (RefPtrWillBeRawPtr<SVGFilterBuilder> builder = filter->buildPrimitives(dummyFilter.get())) {

if (FilterEffect* lastEffect = builder->lastEffect())

lastEffect->externalRepresentation(ts, indent + 1);