Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 134893002: Revert "Explicit space required around NOT/ONLY/AND in CSS MQ." (Closed)

Created:
6 years, 11 months ago by rune
Modified:
6 years, 11 months ago
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Visibility:
Public.

Description

Revert "Explicit space required around NOT/ONLY/AND in CSS MQ." This reverts commit 5f1d4100b0537f0b9aa7efc9bd8d44d618442f78. Conflicts: Source/core/css/CSSGrammar.y.in BUG=333035 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164913

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -54 lines) Patch
M LayoutTests/fast/media/media-query-and.html View 1 chunk +3 lines, -14 lines 0 comments Download
M LayoutTests/fast/media/media-query-and-expected.html View 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/fast/media/media-query-only-not.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/fast/media/media-query-only-not-expected.html View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSGrammar.y View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rune
6 years, 11 months ago (2014-01-10 21:46:48 UTC) #1
esprehn
lgtm, what happened here?
6 years, 11 months ago (2014-01-10 22:19:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/134893002/1
6 years, 11 months ago (2014-01-10 22:25:51 UTC) #3
rune
6 years, 11 months ago (2014-01-10 23:38:27 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=7203
6 years, 11 months ago (2014-01-10 23:51:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/134893002/1
6 years, 11 months ago (2014-01-11 00:14:33 UTC) #6
eseidel
6 years, 11 months ago (2014-01-11 00:37:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r164913 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698