Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 1348903003: third_party/mojo: Remove python/go/dart bindings. (Closed)

Created:
5 years, 3 months ago by yzshen1
Modified:
5 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

third_party/mojo: Remove python/go/dart bindings. This patch also removes some unused tools for downloading prebuilt or dart stuff. BUG=None R=jam@chromium.org, rockot@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/f9493daff38ea46aab8daf14427d314a9700d906

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16864 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/mojo/mojom_bindings_generator.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/mojo/mojom_bindings_generator_explicit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/mojom_bindings_generator_variables.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/BUILD.gn View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/mojo/src/mojo/public/VERSION View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/mojo/src/mojo/public/dart/.analysis_options View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/.gitignore View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/BUILD.gn View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/CHANGELOG.md View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/README.md View 1 chunk +0 lines, -126 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/_sdkext View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/application.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/bindings.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/core.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/application.dart View 1 chunk +0 lines, -133 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/application_connection.dart View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/buffer.dart View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/codec.dart View 1 chunk +0 lines, -877 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/control_message.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/data_pipe.dart View 1 chunk +0 lines, -167 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/drain_data.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/event_stream.dart View 1 chunk +0 lines, -249 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/handle.dart View 1 chunk +0 lines, -144 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/message.dart View 1 chunk +0 lines, -127 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/message_pipe.dart View 1 chunk +0 lines, -153 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/proxy.dart View 1 chunk +0 lines, -170 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/struct.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/stub.dart View 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/types.dart View 1 chunk +0 lines, -260 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/union.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/lib/src/utils.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/pubspec.yaml View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/rules.gni View 1 chunk +0 lines, -614 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/sdk_ext/internal.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/sdk_ext/src/handle_watcher.dart View 1 chunk +0 lines, -353 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/sdk_ext/src/natives.dart View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/sdk_ext/src/timer_queue.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/application/application_impl.go View 1 chunk +0 lines, -176 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/application/connection.go View 1 chunk +0 lines, -176 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/bindings/async_waiter.go View 1 chunk +0 lines, -282 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/bindings/connector.go View 1 chunk +0 lines, -113 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/bindings/decoder.go View 1 chunk +0 lines, -429 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/bindings/encoder.go View 1 chunk +0 lines, -385 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/bindings/interface.go View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/bindings/invalid_handle.go View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/bindings/message.go View 1 chunk +0 lines, -205 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/bindings/router.go View 1 chunk +0 lines, -228 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/bindings/stub.go View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/bindings/util.go View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/system/core.go View 1 chunk +0 lines, -147 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/system/data_pipe.go View 1 chunk +0 lines, -131 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/system/handle.go View 1 chunk +0 lines, -169 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/system/message_pipe.go View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/system/mojo_types.go View 1 chunk +0 lines, -127 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/system/shared_buffer.go View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/system/system.go View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/system/system_android.go View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/system/system_linux.go View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/mojo/src/mojo/public/go/system/system_nacl.go View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/mojo/src/mojo/public/platform/native_cgo/system_cgo.go View 1 chunk +0 lines, -258 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/BUILD.gn View 1 chunk +0 lines, -151 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/c_async_waiter.pxd View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/c_core.pxd View 1 chunk +0 lines, -200 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/c_environment.pxd View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/c_export.pxd View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/c_thunks.pxd View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_application/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_application/application_delegate.py View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_application/application_impl.py View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_application/application_runner.py View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_application/service_provider_impl.py View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_bindings/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_bindings/descriptor.py View 1 chunk +0 lines, -809 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_bindings/interface_reflection.py View 1 chunk +0 lines, -466 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_bindings/messaging.py View 1 chunk +0 lines, -409 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_bindings/promise.py View 1 chunk +0 lines, -221 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_bindings/reflection.py View 1 chunk +0 lines, -310 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_bindings/serialization.py View 1 chunk +0 lines, -309 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_system.pyx View 1 chunk +0 lines, -803 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/mojo_system_impl.pyx View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/rules.gni View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/src/common.h View 1 chunk +0 lines, -107 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/src/common.cc View 1 chunk +0 lines, -190 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/src/python_system_helper.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/mojo/src/mojo/public/python/src/python_system_helper.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/BUILD.gn View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/NETWORK_SERVICE_VERSION View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/encoding_macros.tmpl View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/enum_definition.tmpl View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl View 1 chunk +0 lines, -274 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/module.lib.tmpl View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/module_definition.tmpl View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl View 1 chunk +0 lines, -96 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/union_definition.tmpl View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/encoding_macros.tmpl View 1 chunk +0 lines, -209 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/enum.tmpl View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/interface.tmpl View 1 chunk +0 lines, -229 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/source.tmpl View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/struct.tmpl View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/union.tmpl View 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_dart_generator.py View 1 chunk +0 lines, -497 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_go_generator.py View 1 chunk +0 lines, -373 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_python_generator.py View 1 chunk +0 lines, -246 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/python_templates/module.py.tmpl View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/python_templates/module_macros.tmpl View 1 chunk +0 lines, -49 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/mojom.gni View 6 chunks +5 lines, -63 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/mojom_bindings_generator.py View 2 chunks +1 line, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/mojom_list_outputs.py View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/mojo/src/mojo/public/tools/dart_analyze.py View 1 chunk +0 lines, -148 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/dart_list_mojoms.py View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/dart_list_packages_contents.py View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/dart_package.py View 1 chunk +0 lines, -172 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/dart_package_name.py View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/dart_pkg.py View 1 chunk +0 lines, -338 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/dart_snapshotter.py View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/dartx.py View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/download_archiecture_independent_frameworks.py View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/download_dart_snapshotter.py View 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/download_network_service.py View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/download_shell_binary.py View 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/git/dart_pub_get.py View 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/gn/last_commit_timestamp.py View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/gn/unzip.py View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/mojom_fetcher/build_gn.tmpl View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/mojom_fetcher/mojom_fetcher.py View 1 chunk +0 lines, -196 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/mojom_fetcher/mojom_gn.py View 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/mojom_fetcher/pylib/fetcher/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/mojom_fetcher/pylib/fetcher/dependency.py View 1 chunk +0 lines, -180 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/mojom_fetcher/pylib/fetcher/mojom_directory.py View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/mojom_fetcher/pylib/fetcher/mojom_file.py View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/mojom_fetcher/pylib/fetcher/repository.py View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/mojo/src/mojo/public/tools/pylib/gs.py View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
yzshen1
Hi, John and Ken. Would you please take a look? John: I think this shouldn't ...
5 years, 3 months ago (2015-09-18 17:11:18 UTC) #2
Ken Rockot(use gerrit already)
Looking at build files and the few py script modifications, I believe you've covered everything. ...
5 years, 3 months ago (2015-09-18 17:14:26 UTC) #3
jam
lgtm
5 years, 3 months ago (2015-09-21 16:50:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348903003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348903003/40001
5 years, 3 months ago (2015-09-21 16:56:15 UTC) #6
charlieloveeric3
prepare Mercurial As a first step, you should teach your Mercurial name. So you open ...
5 years, 3 months ago (2015-09-21 16:59:17 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/43332)
5 years, 3 months ago (2015-09-21 18:01:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348903003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348903003/40001
5 years, 3 months ago (2015-09-21 18:10:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/43390)
5 years, 3 months ago (2015-09-21 18:59:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348903003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348903003/40001
5 years, 3 months ago (2015-09-21 19:03:55 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/43421)
5 years, 3 months ago (2015-09-21 19:40:23 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f9493daff38ea46aab8daf14427d314a9700d906 Cr-Commit-Position: refs/heads/master@{#350015}
5 years, 3 months ago (2015-09-21 21:13:31 UTC) #19
yzshen1
5 years, 3 months ago (2015-09-21 21:13:56 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f9493daff38ea46aab8daf14427d314a9700d906 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698