Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1348893003: win: Don't omit frame pointers (Closed)

Created:
5 years, 3 months ago by scottmg
Modified:
5 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/mini_chromium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

win: Don't omit frame pointers Chrome already always does this. Without this, RtlCaptureContext() gets confused in some test cases. Also, add /Zo https://msdn.microsoft.com/en-us/library/dn785163.aspx which is helpful when debugging opt builds. R=mark@chromium.org BUG=crashpad:50 Committed: https://chromium.googlesource.com/chromium/mini_chromium/+/302e4e7d9aa0a8d39ad62b193a4c8a8357ad9d0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M build/common.gypi View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
Oops, after saying in that other thread that *chrome* always does this, it took me ...
5 years, 3 months ago (2015-09-16 21:27:33 UTC) #1
Mark Mentovai
LGTM, although I think that once we replace RtlCaptureContext() (bug crashpad:53), we can let FPO ...
5 years, 3 months ago (2015-09-16 21:30:23 UTC) #2
scottmg
On 2015/09/16 21:30:23, Mark Mentovai - August is over wrote: > LGTM, although I think ...
5 years, 3 months ago (2015-09-16 21:32:25 UTC) #3
scottmg
5 years, 3 months ago (2015-09-16 21:32:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
302e4e7d9aa0a8d39ad62b193a4c8a8357ad9d0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698