Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1385)

Unified Diff: build/common.gypi

Issue 1348893003: win: Don't omit frame pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/mini_chromium@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 95a6b47bd22dd5d0b9c93a732da5e7ba7294e5dd..97d6c380d8a711acaa7828465b434cff8397fef1 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -180,6 +180,13 @@
'RuntimeTypeInfo': 'false',
'BufferSecurityCheck': 'true',
'EnableFunctionLevelLinking': 'true',
+ 'OmitFramePointers': 'false',
+ # The above is not sufficient (http://crbug.com/106711): it simply
+ # eliminates an explicit "/Oy", but both /O2 and /Ox perform FPO
+ # regardless, so we must explicitly disable. We still want the false
+ # setting above to avoid having "/Oy /Oy-" and warnings about
+ # overriding.
+ 'AdditionalOptions': ['/Oy-'],
},
'VCLinkerTool': {
'GenerateDebugInformation': 'true',
@@ -285,6 +292,9 @@
'msvs_settings': {
'VCCLCompilerTool': {
'Optimization': '3',
+ 'AdditionalOptions': [
+ '/Zo', # Improve debugging optimized builds.
+ ],
},
},
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698