Let WebSourceBufferImpl::setMode() update SourceState::sequence_mode_

content/renderer/media/websourcebuffer_impl.cc

Index: content/renderer/media/websourcebuffer_impl.cc
diff --git a/content/renderer/media/websourcebuffer_impl.cc b/content/renderer/media/websourcebuffer_impl.cc
index c9429779d827de2145ffedaa10b58e13746704a6..5901fcb055318d85f4cf1f2aee4ba0c3fdcd1dc2 100644
--- a/content/renderer/media/websourcebuffer_impl.cc
+++ b/content/renderer/media/websourcebuffer_impl.cc
@@ -36,6 +36,22 @@ WebSourceBufferImpl::~WebSourceBufferImpl() {
   DCHECK(!demuxer_) << "Object destroyed w/o removedFromMediaSource() call";
 }
 
+bool WebSourceBufferImpl::setMode(WebSourceBuffer::AppendMode mode) {
+  bool is_sequence_mode = false;
+  switch (mode) {
+    case WebSourceBuffer::AppendModeSegments:
+      break;
+    case WebSourceBuffer::AppendModeSequence:
+      is_sequence_mode = true;
+      break;
+    default:
+      NOTIMPLEMENTED();
+      return false;

[wolenetz, 2014/01/11 00:55:44]

I suspect we want to expose some exception if we reach here, so I added this to
trigger InvalidStateError exception throw by SourceBuffer::setMode().

[acolwell GONE FROM CHROMIUM, 2014/01/11 01:24:36]

No. Please remove this default section so a compiler error happens if the enum
is changed. The Blink code should be protecting this code from any rogue values.
The enum is changed in the future the compiler error will for the person to look
at this code and update the logic appropriately before landing a Blink change
that will send a new value here.

[wolenetz, 2014/01/11 02:15:05]

Done. Also done, per our offline chat, in WebMediaSourceImpl::markEndOfStream(),
which I was using as example.

+  }
+
+  return demuxer_->SetSequenceMode(id_, is_sequence_mode);
+}
+
 blink::WebTimeRanges WebSourceBufferImpl::buffered() {
   media::Ranges<base::TimeDelta> ranges = demuxer_->GetBufferedRanges(id_);
   blink::WebTimeRanges result(ranges.size());