Let WebSourceBufferImpl::setMode() update SourceState::sequence_mode_

content/renderer/media/websourcebuffer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/websourcebuffer_impl.h"
 
 #include "base/float_util.h"
 #include "media/filters/chunk_demuxer.h"
 
 namespace content {
@@ skipping 18 matching lines @@
     const std::string& id, media::ChunkDemuxer* demuxer)
     : id_(id),
       demuxer_(demuxer) {
   DCHECK(demuxer_);
 }
 
 WebSourceBufferImpl::~WebSourceBufferImpl() {
   DCHECK(!demuxer_) << "Object destroyed w/o removedFromMediaSource() call";
 }
 
+bool WebSourceBufferImpl::setMode(WebSourceBuffer::AppendMode mode) {
+  bool is_sequence_mode = false;
+  switch (mode) {
+    case WebSourceBuffer::AppendModeSegments:
+      break;
+    case WebSourceBuffer::AppendModeSequence:
+      is_sequence_mode = true;
+      break;
+    default:
+      NOTIMPLEMENTED();
+      return false;

[wolenetz, 2014/01/11 00:55:44]

I suspect we want to expose some exception if we reach here, so I added this to
trigger InvalidStateError exception throw by SourceBuffer::setMode().

[acolwell GONE FROM CHROMIUM, 2014/01/11 01:24:36]

No. Please remove this default section so a compiler error happens if the enum
is changed. The Blink code should be protecting this code from any rogue values.
The enum is changed in the future the compiler error will for the person to look
at this code and update the logic appropriately before landing a Blink change
that will send a new value here.

[wolenetz, 2014/01/11 02:15:05]

Done. Also done, per our offline chat, in WebMediaSourceImpl::markEndOfStream(),
which I was using as example.

+  }
+
+  return demuxer_->SetSequenceMode(id_, is_sequence_mode);
+}
+
 blink::WebTimeRanges WebSourceBufferImpl::buffered() {
   media::Ranges<base::TimeDelta> ranges = demuxer_->GetBufferedRanges(id_);
   blink::WebTimeRanges result(ranges.size());
   for (size_t i = 0; i < ranges.size(); i++) {
     result[i].start = ranges.start(i).InSecondsF();
     result[i].end = ranges.end(i).InSecondsF();
   }
   return result;
 }
 
@@ skipping 22 matching lines @@
 void WebSourceBufferImpl::setAppendWindowEnd(double end) {
   demuxer_->SetAppendWindowEnd(id_, DoubleToTimeDelta(end));
 }
 
 void WebSourceBufferImpl::removedFromMediaSource() {
   demuxer_->RemoveId(id_);
   demuxer_ = NULL;
 }
 
 }  // namespace content