Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2084)

Unified Diff: content/renderer/media/websourcebuffer_impl.cc

Issue 134883002: Let WebSourceBufferImpl::setMode() update SourceState::sequence_mode_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reference http://crbug.com/333437 in SourceState comment Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/websourcebuffer_impl.cc
diff --git a/content/renderer/media/websourcebuffer_impl.cc b/content/renderer/media/websourcebuffer_impl.cc
index c9429779d827de2145ffedaa10b58e13746704a6..eb54709fc82ea6e564a0984ba49634b8ad3354c4 100644
--- a/content/renderer/media/websourcebuffer_impl.cc
+++ b/content/renderer/media/websourcebuffer_impl.cc
@@ -36,6 +36,21 @@ WebSourceBufferImpl::~WebSourceBufferImpl() {
DCHECK(!demuxer_) << "Object destroyed w/o removedFromMediaSource() call";
}
+bool WebSourceBufferImpl::setMode(WebSourceBuffer::AppendMode mode) {
+ media::ChunkDemuxer::AppendMode demuxerMode = media::ChunkDemuxer::kSegments;
+ switch (mode) {
+ case WebSourceBuffer::AppendModeSegments:
+ break;
+ case WebSourceBuffer::AppendModeSequence:
+ demuxerMode = media::ChunkDemuxer::kSequence;
+ break;
+ default:
acolwell GONE FROM CHROMIUM 2014/01/10 23:10:37 nit: Change switch to a cast and use COMPILE_ASSER
wolenetz 2014/01/11 00:55:44 Done using your other suggestion (use a bool |is_s
+ NOTIMPLEMENTED();
+ }
+
+ return demuxer_->SetAppendMode(id_, demuxerMode);
+}
+
blink::WebTimeRanges WebSourceBufferImpl::buffered() {
media::Ranges<base::TimeDelta> ranges = demuxer_->GetBufferedRanges(id_);
blink::WebTimeRanges result(ranges.size());

Powered by Google App Engine
This is Rietveld 408576698