Let WebSourceBufferImpl::setMode() update SourceState::sequence_mode_

content/renderer/media/websourcebuffer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/websourcebuffer_impl.h"
 
 #include "base/float_util.h"
 #include "media/filters/chunk_demuxer.h"
 
 namespace content {
@@ skipping 18 matching lines @@
     const std::string& id, media::ChunkDemuxer* demuxer)
     : id_(id),
       demuxer_(demuxer) {
   DCHECK(demuxer_);
 }
 
 WebSourceBufferImpl::~WebSourceBufferImpl() {
   DCHECK(!demuxer_) << "Object destroyed w/o removedFromMediaSource() call";
 }
 
+bool WebSourceBufferImpl::setMode(WebSourceBuffer::AppendMode mode) {
+  media::ChunkDemuxer::AppendMode demuxerMode = media::ChunkDemuxer::kSegments;
+  switch (mode) {
+    case WebSourceBuffer::AppendModeSegments:
+      break;
+    case WebSourceBuffer::AppendModeSequence:
+      demuxerMode = media::ChunkDemuxer::kSequence;
+      break;
+    default:

[acolwell GONE FROM CHROMIUM, 2014/01/10 23:10:37]

nit: Change switch to a cast and use COMPILE_ASSERTs to verify that the Blink
and ChunkDemuxer contants match. See WebMediaSourceImpl for an example.

[wolenetz, 2014/01/11 00:55:44]

Done using your other suggestion (use a bool |is_sequence_mode| since there are
only two valid modes). As such, there is no need for COMPILE_ASSERTs, and I
followed the example of using switch from WebMediaSourceImpl::markEndOfStream.

+      NOTIMPLEMENTED();
+  }
+
+  return demuxer_->SetAppendMode(id_, demuxerMode);
+}
+
 blink::WebTimeRanges WebSourceBufferImpl::buffered() {
   media::Ranges<base::TimeDelta> ranges = demuxer_->GetBufferedRanges(id_);
   blink::WebTimeRanges result(ranges.size());
   for (size_t i = 0; i < ranges.size(); i++) {
     result[i].start = ranges.start(i).InSecondsF();
     result[i].end = ranges.end(i).InSecondsF();
   }
   return result;
 }
 
@@ skipping 22 matching lines @@
 void WebSourceBufferImpl::setAppendWindowEnd(double end) {
   demuxer_->SetAppendWindowEnd(id_, DoubleToTimeDelta(end));
 }
 
 void WebSourceBufferImpl::removedFromMediaSource() {
   demuxer_->RemoveId(id_);
   demuxer_ = NULL;
 }
 
 }  // namespace content