Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: src/ic/ic.cc

Issue 1348823003: [hydrogen] Add crash-hunting instrumentation to Hydrogen too (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: add missing heap object check Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | src/ic/x64/ic-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic.cc
diff --git a/src/ic/ic.cc b/src/ic/ic.cc
index 867c9e07d76b0b01173e7ec5c38a7030be2aaac7..99a79d93688091799a237bff03cf9cd214542be2 100644
--- a/src/ic/ic.cc
+++ b/src/ic/ic.cc
@@ -2381,7 +2381,7 @@ RUNTIME_FUNCTION(Runtime_LoadIC_Miss) {
// Sanity check: The loaded value must be a JS-exposed kind of object,
// not something internal (like a Map, or FixedArray). Check this here
// to chase after a rare but recurring crash bug.
- // TODO(jkummerow): Remove this when it has generated a few crash reports.
+ // TODO(chromium:527994): Remove this when we have a few crash reports.
if (!result->IsSmi()) {
InstanceType type =
Handle<HeapObject>::cast(result)->map()->instance_type();
@@ -3130,7 +3130,7 @@ RUNTIME_FUNCTION(Runtime_LoadIC_MissFromStubFailure) {
// Sanity check: The loaded value must be a JS-exposed kind of object,
// not something internal (like a Map, or FixedArray). Check this here
// to chase after a rare but recurring crash bug.
- // TODO(jkummerow): Remove this when it has generated a few crash reports.
+ // TODO(chromium:527994): Remove this when we have a few crash reports.
if (!result->IsSmi()) {
InstanceType type =
Handle<HeapObject>::cast(result)->map()->instance_type();
« no previous file with comments | « src/hydrogen.cc ('k') | src/ic/x64/ic-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698