src/ic/x64/ic-x64.cc - Issue 1348823003: [hydrogen] Add crash-hunting instrumentation to Hydrogen too

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/x64/ic-x64.cc

Issue 1348823003: [hydrogen] Add crash-hunting instrumentation to Hydrogen too (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: add missing heap object check Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/x64/ic-x64.cc

diff --git a/src/ic/x64/ic-x64.cc b/src/ic/x64/ic-x64.cc

index 0d3d07298b9b2d607d65965ba5347ba1af32cef9..ab400e2c8ac6c79c35d932b1488e28eb6747f945 100644

--- a/src/ic/x64/ic-x64.cc

+++ b/src/ic/x64/ic-x64.cc

@@ -680,7 +680,7 @@ void LoadIC::GenerateMiss(MacroAssembler* masm, int stress) {

// Sanity check: The receiver must be a JS-exposed kind of object,

// not something internal (like a Map, or FixedArray). Check this here

// to chase after a rare but recurring crash bug.

- // TODO(jkummerow): Remove this when it has generated a few crash reports.

+ // TODO(chromium:527994): Remove this when we have a few crash reports.

Label ok, sound_alarm;

__ JumpIfSmi(receiver, &ok, Label::kNear);

« no previous file with comments | « src/ic/ic.cc ('k') | no next file » | no next file with comments »