Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1348823003: [hydrogen] Add crash-hunting instrumentation to Hydrogen too (Closed)

Created:
5 years, 3 months ago by Jakob Kummerow
Modified:
5 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[hydrogen] Add crash-hunting instrumentation to Hydrogen too This extends instrumentation added in r30683 and r30768 to cover the possibility that the root cause we're after is in optimized code. This CL is intended to be reverted in a couple of days, but should cause no harm while it's in the tree (we would crash anyway). BUG=chromium:527994 LOG=n Committed: https://crrev.com/491b9e29a0909374eb75334632438509f1afc732 Cr-Commit-Position: refs/heads/master@{#30819}

Patch Set 1 #

Patch Set 2 : add bug number to TODO comments #

Patch Set 3 : add missing heap object check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M src/full-codegen/x64/full-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Jakob Kummerow
5 years, 3 months ago (2015-09-17 19:44:57 UTC) #2
mvstanton
LGTM but I'd like to attach the bug number to the 2 (or 3?) places ...
5 years, 3 months ago (2015-09-17 21:13:35 UTC) #3
Jakob Kummerow
ACK, new patch set uploaded.
5 years, 3 months ago (2015-09-18 08:14:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348823003/20001
5 years, 3 months ago (2015-09-18 08:14:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/9876)
5 years, 3 months ago (2015-09-18 08:23:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348823003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348823003/40001
5 years, 3 months ago (2015-09-18 08:49:54 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-18 09:15:45 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 09:15:57 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/491b9e29a0909374eb75334632438509f1afc732
Cr-Commit-Position: refs/heads/master@{#30819}

Powered by Google App Engine
This is Rietveld 408576698