Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: fpdfsdk/src/jsapi/fxjs_v8.cpp

Issue 1348693003: Remove several dead functions from fxjs_v8.{cpp,h} (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/include/jsapi/fxjs_v8.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/src/jsapi/fxjs_v8.cpp
diff --git a/fpdfsdk/src/jsapi/fxjs_v8.cpp b/fpdfsdk/src/jsapi/fxjs_v8.cpp
index 2c17628dbc7028597e9c1b4d1251cb838d87fbc3..381bfbad7f5c3e4d9f094470c7980e770cac94f2 100644
--- a/fpdfsdk/src/jsapi/fxjs_v8.cpp
+++ b/fpdfsdk/src/jsapi/fxjs_v8.cpp
@@ -416,20 +416,6 @@ v8::Local<v8::Object> FXJS_NewFxDynamicObj(v8::Isolate* pIsolate,
return obj;
}
-v8::Local<v8::Object> FXJS_GetStaticObj(v8::Isolate* pIsolate, int nObjDefnID) {
- v8::Isolate::Scope isolate_scope(pIsolate);
- CFX_PtrArray* pArray = (CFX_PtrArray*)pIsolate->GetData(g_embedderDataSlot);
- if (!pArray)
- return v8::Local<v8::Object>();
-
- if (nObjDefnID < 0 || nObjDefnID >= pArray->GetSize())
- return v8::Local<v8::Object>();
- CFXJS_ObjDefintion* pObjDef = (CFXJS_ObjDefintion*)pArray->GetAt(nObjDefnID);
- v8::Local<v8::Object> obj =
- v8::Local<v8::Object>::New(pIsolate, pObjDef->m_StaticObj);
- return obj;
-}
-
v8::Local<v8::Object> FXJS_GetThisObj(v8::Isolate* pIsolate) {
// Return the global object.
v8::Isolate::Scope isolate_scope(pIsolate);
@@ -567,10 +553,6 @@ v8::Local<v8::String> FXJS_WSToJSString(v8::Isolate* pIsolate,
v8::NewStringType::kNormal).ToLocalChecked();
}
-v8::Local<v8::Value> FXJS_GetObjectValue(v8::Local<v8::Object> pObj) {
- return pObj;
-}
-
v8::Local<v8::Value> FXJS_GetObjectElement(v8::Isolate* pIsolate,
v8::Local<v8::Object> pObj,
const wchar_t* PropertyName) {
@@ -736,12 +718,6 @@ v8::Local<v8::Value> FXJS_NewString(v8::Isolate* pIsolate,
return FXJS_WSToJSString(pIsolate, string);
}
-v8::Local<v8::Value> FXJS_NewString(v8::Isolate* pIsolate,
- const wchar_t* string,
- unsigned nLen) {
- return FXJS_WSToJSString(pIsolate, string, nLen);
-}
-
v8::Local<v8::Value> FXJS_NewNull() {
return v8::Local<v8::Value>();
}
@@ -750,25 +726,6 @@ v8::Local<v8::Value> FXJS_NewDate(v8::Isolate* pIsolate, double d) {
return v8::Date::New(pIsolate->GetCurrentContext(), d).ToLocalChecked();
}
-v8::Local<v8::Value> FXJS_NewValue(v8::Isolate* pIsolate) {
- return v8::Local<v8::Value>();
-}
-
-v8::Local<v8::Value> FXJS_GetListValue(v8::Isolate* pIsolate,
- v8::Local<v8::Value> pList,
- int index) {
- v8::Local<v8::Context> context = pIsolate->GetCurrentContext();
- if (!pList.IsEmpty() && pList->IsObject()) {
- v8::Local<v8::Object> obj;
- if (pList->ToObject(context).ToLocal(&obj)) {
- v8::Local<v8::Value> val;
- if (obj->Get(context, index).ToLocal(&val))
- return val;
- }
- }
- return v8::Local<v8::Value>();
-}
-
int FXJS_ToInt32(v8::Isolate* pIsolate, v8::Local<v8::Value> pValue) {
if (pValue.IsEmpty())
return 0;
« no previous file with comments | « fpdfsdk/include/jsapi/fxjs_v8.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698