Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 134863003: [SyncFS] Refactor MetadataDatabase on dirty flag handling and sync-root creation (Closed)

Created:
6 years, 10 months ago by tzik
Modified:
6 years, 10 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, kinuko+watch, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] Refactor MetadataDatabase on dirty flag handling and sync-root creation * Make leveldb::WriteBatch nullable to reduce extra write. * Consolidate dirty flag handling. * Simplify sync-root creation BUG=331988 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248974

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : testfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -70 lines) Patch
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 1 13 chunks +50 lines, -66 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 1 2 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
tzik
PTL.
6 years, 10 months ago (2014-02-04 13:40:31 UTC) #1
nhiroki
lgtm
6 years, 10 months ago (2014-02-05 03:34:58 UTC) #2
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 10 months ago (2014-02-05 09:06:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/134863003/30001
6 years, 10 months ago (2014-02-05 09:12:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 10:07:53 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=221649
6 years, 10 months ago (2014-02-05 10:07:53 UTC) #6
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 10 months ago (2014-02-05 10:47:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/134863003/360002
6 years, 10 months ago (2014-02-05 10:54:01 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 12:16:21 UTC) #9
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=45102
6 years, 10 months ago (2014-02-05 12:16:22 UTC) #10
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 10 months ago (2014-02-05 13:01:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/134863003/360002
6 years, 10 months ago (2014-02-05 13:02:40 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 13:07:21 UTC) #13
Message was sent while issue was closed. 
Change committed as 248974

Powered by Google App Engine
This is Rietveld 408576698