Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1348603003: [BackgroundSync] Move BackgroundSyncState from proto to mojo (Closed)

Created:
5 years, 3 months ago by jkarlin
Modified:
5 years, 3 months ago
CC:
chromium-reviews, tim+watch_chromium.org, viettrungluu+watch_chromium.org, qsr+mojo_chromium.org, zea+watch_chromium.org, Aaron Boodman, maxbogue+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[BackgroundSync] Move BackgroundSyncState from proto to mojo There is a SyncState enum in background_sync.proto but we don't actually need to store it to disk. So remove the protobuf enum to a mojo definition (since we'll need it for mojo in registration.done). BUG=502214 Committed: https://crrev.com/fffab7c9a274eaf70a12602c2dd3ba81caf318ed Cr-Commit-Position: refs/heads/master@{#349653}

Patch Set 1 #

Patch Set 2 : Android fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -26 lines) Patch
M content/browser/background_sync/background_sync.proto View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/background_sync/background_sync_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/background_sync/background_sync_manager.cc View 1 7 chunks +6 lines, -14 lines 0 comments Download
M content/browser/background_sync/background_sync_registration.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/background_sync/background_sync_registration_handle.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/background_sync_service.mojom View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
jkarlin
Michael: PTAL at everything tsepez: PTAL at the mojo change
5 years, 3 months ago (2015-09-17 00:52:33 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 3 months ago (2015-09-17 12:35:46 UTC) #3
Tom Sepez
mojom lgtm
5 years, 3 months ago (2015-09-17 18:14:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348603003/1
5 years, 3 months ago (2015-09-17 18:20:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/121012) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-17 18:36:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348603003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348603003/20001
5 years, 3 months ago (2015-09-18 11:31:14 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-18 12:11:48 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 12:12:21 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fffab7c9a274eaf70a12602c2dd3ba81caf318ed
Cr-Commit-Position: refs/heads/master@{#349653}

Powered by Google App Engine
This is Rietveld 408576698