Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1348523003: Revert "Populate EEP estimate in NQE" (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
tbansal1
CC:
chromium-reviews, cbentzel+watch_chromium.org, Randy Smith (Not in Mondays), asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Populate EEP estimate in NQE" This reverts commit 9ee5d296239e3bc21b5c70259242ce6c4cefc96b. NetworkQualityEstimatorTest failing on multiple bots. BUG=472685 TBR=tbansal@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a6a1fd98de7c7d8a405fe572a52781261baaaae9 Cr-Commit-Position: refs/heads/master@{#349065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -508 lines) Patch
M chrome/browser/android/net/external_estimate_provider_android.h View 2 chunks +16 lines, -5 lines 0 comments Download
M chrome/browser/android/net/external_estimate_provider_android.cc View 3 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/android/net/external_estimate_provider_android_unittest.cc View 4 chunks +1 line, -38 lines 0 comments Download
M net/base/external_estimate_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/base/network_quality_estimator.h View 5 chunks +3 lines, -32 lines 0 comments Download
M net/base/network_quality_estimator.cc View 6 chunks +5 lines, -66 lines 0 comments Download
M net/base/network_quality_estimator_unittest.cc View 13 chunks +46 lines, -326 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Lei Zhang
TBR
5 years, 3 months ago (2015-09-16 01:51:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348523003/1
5 years, 3 months ago (2015-09-16 01:52:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 01:53:25 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a6a1fd98de7c7d8a405fe572a52781261baaaae9 Cr-Commit-Position: refs/heads/master@{#349065}
5 years, 3 months ago (2015-09-16 01:54:51 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:52:52 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a6a1fd98de7c7d8a405fe572a52781261baaaae9
Cr-Commit-Position: refs/heads/master@{#349065}

Powered by Google App Engine
This is Rietveld 408576698