third_party/WebKit/Source/core/page/Page.cpp - Issue 1348503003: One AXObjectCache per frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 1348503003: One AXObjectCache per frame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix issues in AutomationApiTest.Events Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/Page.cpp

diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp

index c0143018d66ce8160d10b5cb5e116f953ad3cfda..428f5150af9cbd5cfb5abf8eb82eb4ab54ef8373 100644

--- a/third_party/WebKit/Source/core/page/Page.cpp

+++ b/third_party/WebKit/Source/core/page/Page.cpp

@@ -477,9 +477,10 @@ void Page::settingsChanged(SettingsDelegate::ChangeType changeType)

}

break;

case SettingsDelegate::AccessibilityStateChange:

- if (!mainFrame() || !mainFrame()->isLocalFrame())

- break;

- deprecatedLocalMainFrame()->document()->axObjectCacheOwner().clearAXObjectCache();

+ for (Frame* frame = mainFrame(); frame; frame = frame->tree().traverseNext()) {

+ if (frame->isLocalFrame())

+ toLocalFrame(frame)->document()->clearAXObjectCache();

+ }

break;

case SettingsDelegate::ViewportRuleChange:

{