Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1348503003: One AXObjectCache per frame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix issues in AutomationApiTest.Events Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/page/Page.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index d27feb25d9efcfc466580789bf8518fade265c11..1cac75a64daa487583d57afb2ca1a9f5f6701305 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -221,10 +221,8 @@ void FrameView::reset()
void FrameView::removeFromAXObjectCache()
{
- if (AXObjectCache* cache = axObjectCache()) {
- cache->remove(this);
+ if (AXObjectCache* cache = axObjectCache())
cache->childrenChanged(m_frame->pagePopupOwner());
- }
}
void FrameView::init()
@@ -2959,8 +2957,6 @@ void FrameView::setLayoutSizeInternal(const IntSize& size)
void FrameView::didAddScrollbar(Scrollbar* scrollbar, ScrollbarOrientation orientation)
{
ScrollableArea::didAddScrollbar(scrollbar, orientation);
- if (AXObjectCache* cache = axObjectCache())
- cache->handleScrollbarUpdate(this);
}
void FrameView::setTopControlsViewportAdjustment(float adjustment)
@@ -2998,8 +2994,6 @@ void FrameView::setHasHorizontalScrollbar(bool hasBar)
m_horizontalScrollbar->styleChanged();
} else {
willRemoveScrollbar(m_horizontalScrollbar.get(), HorizontalScrollbar);
- if (AXObjectCache* cache = axObjectCache())
- cache->remove(m_horizontalScrollbar.get());
// If the scrollbar has been marked as overlapping the window resizer,
// then its removal should reduce the count.
if (m_horizontalScrollbar->overlapsResizer())
@@ -3007,8 +3001,6 @@ void FrameView::setHasHorizontalScrollbar(bool hasBar)
removeChild(m_horizontalScrollbar.get());
m_horizontalScrollbar->disconnectFromScrollableArea();
m_horizontalScrollbar = nullptr;
- if (AXObjectCache* cache = axObjectCache())
- cache->handleScrollbarUpdate(this);
}
invalidateScrollCorner(scrollCornerRect());
@@ -3026,8 +3018,6 @@ void FrameView::setHasVerticalScrollbar(bool hasBar)
m_verticalScrollbar->styleChanged();
} else {
willRemoveScrollbar(m_verticalScrollbar.get(), VerticalScrollbar);
- if (AXObjectCache* cache = axObjectCache())
- cache->remove(m_verticalScrollbar.get());
// If the scrollbar has been marked as overlapping the window resizer,
// then its removal should reduce the count.
if (m_verticalScrollbar->overlapsResizer())
@@ -3035,8 +3025,6 @@ void FrameView::setHasVerticalScrollbar(bool hasBar)
removeChild(m_verticalScrollbar.get());
m_verticalScrollbar->disconnectFromScrollableArea();
m_verticalScrollbar = nullptr;
- if (AXObjectCache* cache = axObjectCache())
- cache->handleScrollbarUpdate(this);
}
invalidateScrollCorner(scrollCornerRect());
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/page/Page.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698