android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java - Issue 1348473003: Do not cast Visual State Callback request_id argument to long.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

Issue 1348473003: Do not cast Visual State Callback request_id argument to long. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

index 65b625c90773acc012649ab44eb3725f97d53e63..9750dd4723a8f3af245772595e71b5a6ae052217 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

@@ -121,7 +121,7 @@ public class VisualStateTest extends AwTestBase {

runTestOnUiThread(new Runnable() {

@Override

public void run() {

- final long requestId = 20;

+ final long requestId = 0x123456789abcdef0L; // ensure requestId is not truncated.

awContents.insertVisualStateCallback(requestId,

new AwContents.VisualStateCallback() {

@Override

« no previous file with comments | « no previous file | android_webview/native/aw_contents.h » ('j') | no next file with comments »