Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1348463002: Remove the 'gyp_config' concept from MB. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews, nodir, Bons, Zhen Wang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the 'gyp_config' concept from MB. Previously MB would try to ensure that the build directory passed to it matched the expected gyp configuration for the bot (i.e. that we would not pass "//out/Debug" as a path for a release bot). Making this work correctly was awkward for the Win x64 bots (which use Release_x64 instead of Release), and it's not clear that this check would ever actually catch a real problem. So, this patch deletes all of the 'gyp_config' logic instead and simplifies things. TBR=scottmg@chromium.org BUG=481692 Committed: https://crrev.com/fae80e312dba6818315f4f8f0c3a1d85f6f4f9fb Cr-Commit-Position: refs/heads/master@{#349043}

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/type value/type values #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -41 lines) Patch
M tools/mb/docs/user_guide.md View 1 3 chunks +2 lines, -5 lines 0 comments Download
M tools/mb/mb.py View 7 chunks +9 lines, -30 lines 0 comments Download
M tools/mb/mb_config.pyl View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/mb/mb_unittest.py View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Dirk Pranke
5 years, 3 months ago (2015-09-15 22:24:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348463002/1
5 years, 3 months ago (2015-09-15 22:25:20 UTC) #3
Dirk Pranke
5 years, 3 months ago (2015-09-15 22:27:15 UTC) #4
Dirk Pranke
This should fix the build failures on the Win x64 Builder on chromium.perf that started ...
5 years, 3 months ago (2015-09-15 22:28:02 UTC) #5
scottmg
lgtm https://codereview.chromium.org/1348463002/diff/1/tools/mb/docs/user_guide.md File tools/mb/docs/user_guide.md (right): https://codereview.chromium.org/1348463002/diff/1/tools/mb/docs/user_guide.md#newcode185 tools/mb/docs/user_guide.md:185: mixins; gyp_defines and gn_args values are concatenated, and ...
5 years, 3 months ago (2015-09-15 22:32:26 UTC) #6
Dirk Pranke
https://codereview.chromium.org/1348463002/diff/1/tools/mb/docs/user_guide.md File tools/mb/docs/user_guide.md (right): https://codereview.chromium.org/1348463002/diff/1/tools/mb/docs/user_guide.md#newcode185 tools/mb/docs/user_guide.md:185: mixins; gyp_defines and gn_args values are concatenated, and the ...
5 years, 3 months ago (2015-09-15 22:37:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348463002/20001
5 years, 3 months ago (2015-09-15 22:37:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-16 00:16:27 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fae80e312dba6818315f4f8f0c3a1d85f6f4f9fb Cr-Commit-Position: refs/heads/master@{#349043}
5 years, 3 months ago (2015-09-16 00:17:42 UTC) #12
Dirk Pranke
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1349463003/ by dpranke@chromium.org. ...
5 years, 3 months ago (2015-09-16 00:23:44 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:51:36 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fae80e312dba6818315f4f8f0c3a1d85f6f4f9fb
Cr-Commit-Position: refs/heads/master@{#349043}

Powered by Google App Engine
This is Rietveld 408576698