Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: tools/mb/mb_unittest.py

Issue 1348463002: Remove the 'gyp_config' concept from MB. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/type value/type values Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/mb/mb_config.pyl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb_unittest.py
diff --git a/tools/mb/mb_unittest.py b/tools/mb/mb_unittest.py
index 8c76e5048bed8c724a438957f587afea9cd49d26..a6f2789f59777995d10234700d30e64f842f2188 100755
--- a/tools/mb/mb_unittest.py
+++ b/tools/mb/mb_unittest.py
@@ -121,11 +121,9 @@ TEST_CONFIG = """\
},
'rel': {
'gn_args': 'is_debug=false',
- 'gyp_config': 'Release',
},
'debug': {
'gn_args': 'is_debug=true',
- 'gyp_config': 'Debug',
},
},
'private_configs': ['private'],
@@ -304,7 +302,7 @@ class UnitTest(unittest.TestCase):
def test_gyp_lookup_goma_dir_expansion(self):
self.check(['lookup', '-c', 'gyp_rel_bot', '-g', '/foo'], ret=0,
out=("python build/gyp_chromium -G 'output_dir=<path>' "
- "-G config=Release -D goma=1 -D gomadir=/foo\n"))
+ "-D goma=1 -D gomadir=/foo\n"))
def test_help(self):
orig_stdout = sys.stdout
« no previous file with comments | « tools/mb/mb_config.pyl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698