Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: lib/runtime/dart/core.js

Issue 1348453004: fix some errors in our SDK, mostly around numbers (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/convert.js ('k') | lib/runtime/dart/js.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/core.js
diff --git a/lib/runtime/dart/core.js b/lib/runtime/dart/core.js
index 7758ec7d69a34a63141a34a01a0738b9b54e5e1a..b104bb5b4ccf82dd5be61037e6c17a59138dbe2b 100644
--- a/lib/runtime/dart/core.js
+++ b/lib/runtime/dart/core.js
@@ -550,9 +550,9 @@ dart_library.library('dart/core', null, /* Imports */[
if (dart.notNull(this.inMicroseconds) < 0) {
return `-${this['unary-']()}`;
}
- let twoDigitMinutes = twoDigits(this.inMinutes[dartx.remainder](Duration.MINUTES_PER_HOUR));
- let twoDigitSeconds = twoDigits(this.inSeconds[dartx.remainder](Duration.SECONDS_PER_MINUTE));
- let sixDigitUs = sixDigits(this.inMicroseconds[dartx.remainder](Duration.MICROSECONDS_PER_SECOND));
+ let twoDigitMinutes = twoDigits(dart.asInt(this.inMinutes[dartx.remainder](Duration.MINUTES_PER_HOUR)));
+ let twoDigitSeconds = twoDigits(dart.asInt(this.inSeconds[dartx.remainder](Duration.SECONDS_PER_MINUTE)));
+ let sixDigitUs = sixDigits(dart.asInt(this.inMicroseconds[dartx.remainder](Duration.MICROSECONDS_PER_SECOND)));
return `${this.inHours}:${twoDigitMinutes}:${twoDigitSeconds}.${sixDigitUs}`;
}
get isNegative() {
@@ -607,7 +607,7 @@ dart_library.library('dart/core', null, /* Imports */[
Error() {
}
static safeToString(object) {
- if (dart.is(object, num) || typeof object == 'boolean' || null == object) {
+ if (typeof object == 'number' || typeof object == 'boolean' || null == object) {
return dart.toString(object);
}
if (typeof object == 'string') {
@@ -1599,7 +1599,7 @@ dart_library.library('dart/core', null, /* Imports */[
if (this[_start] == null) {
return 0;
}
- return this[_stop] == null ? dart.notNull(Stopwatch._now()) - dart.notNull(this[_start]) : dart.notNull(this[_stop]) - dart.notNull(this[_start]);
+ return dart.asInt(this[_stop] == null ? dart.notNull(Stopwatch._now()) - dart.notNull(this[_start]) : dart.notNull(this[_stop]) - dart.notNull(this[_start]));
}
get elapsed() {
return new Duration({microseconds: this.elapsedMicroseconds});
@@ -1788,7 +1788,7 @@ dart_library.library('dart/core', null, /* Imports */[
this[_currentCodePoint] = null;
}
get current() {
- return this[_currentCodePoint];
+ return dart.asInt(this[_currentCodePoint]);
}
get currentSize() {
return dart.notNull(this[_nextPosition]) - dart.notNull(this[_position]);
@@ -1971,7 +1971,7 @@ dart_library.library('dart/core', null, /* Imports */[
get port() {
if (this[_port] == null)
return Uri._defaultPort(this.scheme);
- return this[_port];
+ return dart.asInt(this[_port]);
}
static _defaultPort(scheme) {
if (scheme == "http")
@@ -2370,7 +2370,7 @@ dart_library.library('dart/core', null, /* Imports */[
if (port != null) {
port = Uri._makePort(port, scheme);
} else {
- port = this[_port];
+ port = dart.asInt(this[_port]);
if (dart.notNull(schemeChanged)) {
port = Uri._makePort(port, scheme);
}
@@ -2831,7 +2831,7 @@ dart_library.library('dart/core', null, /* Imports */[
}
targetUserInfo = this[_userInfo];
targetHost = this[_host];
- targetPort = this[_port];
+ targetPort = dart.asInt(this[_port]);
}
}
let fragment = dart.notNull(reference.hasFragment) ? reference.fragment : null;
« no previous file with comments | « lib/runtime/dart/convert.js ('k') | lib/runtime/dart/js.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698