lib/runtime/dart/convert.js - Issue 1348453004: fix some errors in our SDK, mostly around numbers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/runtime/dart/convert.js

Issue 1348453004: fix some errors in our SDK, mostly around numbers (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/runtime/dart/convert.js

diff --git a/lib/runtime/dart/convert.js b/lib/runtime/dart/convert.js

index 5f9dc9e2af01b25bd848a28c3c6eba1b85f57548..03a825aa066c17bac790629851fe03d5f8eafa6c 100644

--- a/lib/runtime/dart/convert.js

+++ b/lib/runtime/dart/convert.js

@@ -1206,7 +1206,7 @@ dart_library.library('dart/convert', null, /* Imports */[

}

writeJsonValue(object) {

- if (dart.is(object, core.num)) {

+ if (typeof object == 'number') {

if (!dart.notNull(dart.as(dart.dload(object, 'isFinite'), core.bool)))

return false;

this.writeNumber(dart.as(object, core.num));

« no previous file with comments | « lib/runtime/dart/collection.js ('k') | lib/runtime/dart/core.js » ('j') | no next file with comments »