Issue 1348393007: Merge to XFA: Remove CJS_RuntimeFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1348393007: Merge to XFA: Remove CJS_RuntimeFactory (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Remove CJS_RuntimeFactory New edits in: fpdfsdk/include/fpdfxfa/fpdfxfa_app.h fpdfsdk/include/javascript/IJavaScript.h fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp (cherry picked from commit bca779d0957965eb2ebfad5479e0894844749626) Original Review URL: https://codereview.chromium.org/1360523004 . R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/854a7f65b70d40225a53890a68a57f5c13cf268c

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -62 lines)			Patch
M	fpdfsdk/include/fpdfxfa/fpdfxfa_app.h	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	fpdfsdk/include/fsdk_mgr.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	fpdfsdk/include/javascript/IJavaScript.h	View	2 chunks	+2 lines, -19 lines	0 comments	Download
M	fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	fpdfsdk/src/fsdk_mgr.cpp	View	4 chunks	+3 lines, -7 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	1 chunk	+0 lines, -22 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

5 years, 3 months ago (2015-09-22 00:07:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
854a7f65b70d40225a53890a68a57f5c13cf268c (presubmit successful).