Remove CJS_RuntimeFactory

Remove CJS_RuntimeFactory

The Factory Design Pattern isn't buying us anything here over just new'ing
the object we want.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/bca779d0957965eb2ebfad5479e0894844749626

[Tom Sepez, 2015-09-21 22:11:21]

Lei, for review.

[Tom Sepez, 2015-09-21 22:12:16]

https://codereview.chromium.org/1360523004/diff/1/fpdfsdk/src/fsdk_mgr.cpp
File fpdfsdk/src/fsdk_mgr.cpp (left):

https://codereview.chromium.org/1360523004/diff/1/fpdfsdk/src/fsdk_mgr.cpp#ol...
fpdfsdk/src/fsdk_mgr.cpp:222: m_pJSRuntimeFactory->AddRef();
Yep, we're ref-counting a static object here :).

[Lei Zhang, 2015-09-21 23:16:05]

lgtm

https://codereview.chromium.org/1360523004/diff/1/fpdfsdk/src/fsdk_mgr.cpp
File fpdfsdk/src/fsdk_mgr.cpp (right):

https://codereview.chromium.org/1360523004/diff/1/fpdfsdk/src/fsdk_mgr.cpp#ne...
fpdfsdk/src/fsdk_mgr.cpp:223: delete m_pJSRuntime;
Can we convert |m_pJSRuntime| to a unique_ptr while we are here?

[Tom Sepez, 2015-09-21 23:28:52]

https://codereview.chromium.org/1360523004/diff/1/fpdfsdk/src/fsdk_mgr.cpp
File fpdfsdk/src/fsdk_mgr.cpp (right):

https://codereview.chromium.org/1360523004/diff/1/fpdfsdk/src/fsdk_mgr.cpp#ne...
fpdfsdk/src/fsdk_mgr.cpp:223: delete m_pJSRuntime;
On 2015/09/21 23:16:05, Lei Zhang wrote:
> Can we convert |m_pJSRuntime| to a unique_ptr while we are here?

Done.

[Tom Sepez, 2015-09-21 23:29:25]

Committed patchset #2 (id:20001) manually as
bca779d0957965eb2ebfad5479e0894844749626 (presubmit successful).