Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(577)

Issue 1360523004: Remove CJS_RuntimeFactory (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove CJS_RuntimeFactory The Factory Design Pattern isn't buying us anything here over just new'ing the object we want. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/bca779d0957965eb2ebfad5479e0894844749626

Patch Set 1 #

Total comments: 3

Patch Set 2 : unique_ptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -58 lines) Patch
M fpdfsdk/include/fsdk_mgr.h View 1 3 chunks +1 line, -4 lines 0 comments Download
M fpdfsdk/include/javascript/IJavaScript.h View 1 chunk +2 lines, -19 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 3 chunks +3 lines, -13 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tom Sepez
Lei, for review.
5 years ago (2015-09-21 22:11:21 UTC) #1
Tom Sepez
https://codereview.chromium.org/1360523004/diff/1/fpdfsdk/src/fsdk_mgr.cpp File fpdfsdk/src/fsdk_mgr.cpp (left): https://codereview.chromium.org/1360523004/diff/1/fpdfsdk/src/fsdk_mgr.cpp#oldcode222 fpdfsdk/src/fsdk_mgr.cpp:222: m_pJSRuntimeFactory->AddRef(); Yep, we're ref-counting a static object here :).
5 years ago (2015-09-21 22:12:16 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1360523004/diff/1/fpdfsdk/src/fsdk_mgr.cpp File fpdfsdk/src/fsdk_mgr.cpp (right): https://codereview.chromium.org/1360523004/diff/1/fpdfsdk/src/fsdk_mgr.cpp#newcode223 fpdfsdk/src/fsdk_mgr.cpp:223: delete m_pJSRuntime; Can we convert |m_pJSRuntime| to a ...
5 years ago (2015-09-21 23:16:05 UTC) #3
Tom Sepez
https://codereview.chromium.org/1360523004/diff/1/fpdfsdk/src/fsdk_mgr.cpp File fpdfsdk/src/fsdk_mgr.cpp (right): https://codereview.chromium.org/1360523004/diff/1/fpdfsdk/src/fsdk_mgr.cpp#newcode223 fpdfsdk/src/fsdk_mgr.cpp:223: delete m_pJSRuntime; On 2015/09/21 23:16:05, Lei Zhang wrote: > ...
5 years ago (2015-09-21 23:28:52 UTC) #4
Tom Sepez
5 years ago (2015-09-21 23:29:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bca779d0957965eb2ebfad5479e0894844749626 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698