Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: sync/test/engine/test_id_factory.h

Issue 1348313003: Cleanup: Pass std::string as const reference from sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mark |name| argument as unused in FakeSyncManagerFactory::CreateSyncManager Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/test/engine/mock_connection_manager.cc ('k') | sync/test/fake_server/bookmark_entity.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/test/engine/test_id_factory.h
diff --git a/sync/test/engine/test_id_factory.h b/sync/test/engine/test_id_factory.h
index 33347297632af47b65f0bc59dffe93106f7988f7..40a3b5b0f9bf31e2c05123f3ac3e88d7a8c1af76 100644
--- a/sync/test/engine/test_id_factory.h
+++ b/sync/test/engine/test_id_factory.h
@@ -36,12 +36,12 @@ class TestIdFactory {
}
// Create a local ID from a name.
- static syncable::Id MakeLocal(std::string name) {
+ static syncable::Id MakeLocal(const std::string& name) {
return syncable::Id::CreateFromClientString(std::string("lient ") + name);
}
// Create a server ID from a string name.
- static syncable::Id MakeServer(std::string name) {
+ static syncable::Id MakeServer(const std::string& name) {
return syncable::Id::CreateFromServerId(std::string("erver ") + name);
}
« no previous file with comments | « sync/test/engine/mock_connection_manager.cc ('k') | sync/test/fake_server/bookmark_entity.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698