runtime/vm/intermediate_language_mips.cc - Issue 13483018: Introduces a second temporary register for MIPS assembler macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 13483018: Introduces a second temporary register for MIPS assembler macros. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_mips.cc

===================================================================

--- runtime/vm/intermediate_language_mips.cc (revision 20999)

+++ runtime/vm/intermediate_language_mips.cc (working copy)

@@ -87,8 +87,7 @@

const int sp_fp_dist = compiler->StackSize() + (-kFirstLocalSlotIndex - 1);

__ subu(T2, FP, SP);

- __ addiu(T2, T2, Immediate(-sp_fp_dist * kWordSize));

- __ beq(T2, ZR, &stack_ok);

+ __ BranchEqual(T2, sp_fp_dist * kWordSize, &stack_ok);

__ break_(0);

__ Bind(&stack_ok);

@@ -537,11 +536,10 @@

CheckStackOverflowSlowPath* slow_path = new CheckStackOverflowSlowPath(this);

compiler->AddSlowPathCode(slow_path);

- __ LoadImmediate(TMP, Isolate::Current()->stack_limit_address());

+ __ LoadImmediate(TMP1, Isolate::Current()->stack_limit_address());

- __ lw(TMP, Address(TMP));

- __ subu(TMP, SP, TMP);

- __ blez(TMP, slow_path->entry_label());

+ __ lw(TMP1, Address(TMP1));

+ __ BranchLessEqual(SP, TMP1, slow_path->entry_label());

__ Bind(slow_path->exit_label());

}

« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »