Unify the way cctest initalizes the VM for each test case.

Unify the way cctest initalizes the VM for each test case.

R=svenpanne@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=14199

[Michael Starzinger, 2013-04-08 18:07:39]

Precursor to being able to change the way we setup the isolate. There is now a
single choke-point in CcTest::InitializeVM() that all test cases go through.

[Sven Panne, 2013-04-09 07:26:28]

https://codereview.chromium.org/13483017/diff/1/test/cctest/cctest.h
File test/cctest/cctest.h (right):

https://codereview.chromium.org/13483017/diff/1/test/cctest/cctest.h#newcode67
test/cctest/cctest.h:67: enum CcTestExtensionFlags {
Using EnumSet here would be simpler and actually more readable. This avoids our
common confusion between an element and a set of elements on the type level.
Using "CcExtensionFlag" is a more appropriate then, too.

https://codereview.chromium.org/13483017/diff/1/test/cctest/cctest.h#newcode94
test/cctest/cctest.h:94: static void InitializeVM(int extensions =
NO_EXTENSIONS);
Use EnumSet<CcTestExtensionFlag> (or perhaps a typedef of it) as a parameter.

https://codereview.chromium.org/13483017/diff/1/test/cctest/test-assembler-mi...
File test/cctest/test-assembler-mips.cc (right):

https://codereview.chromium.org/13483017/diff/1/test/cctest/test-assembler-mi...
test/cctest/test-assembler-mips.cc:47: #define __ assm.
If it is really OK to remove the FLAG_disable_native_files line here, we should
probably nuke this flag.

[Michael Starzinger, 2013-04-09 09:04:00]

https://codereview.chromium.org/13483017/diff/1/test/cctest/cctest.h
File test/cctest/cctest.h (right):

https://codereview.chromium.org/13483017/diff/1/test/cctest/cctest.h#newcode67
test/cctest/cctest.h:67: enum CcTestExtensionFlags {
On 2013/04/09 07:26:28, Sven Panne wrote:
> Using EnumSet here would be simpler and actually more readable. This avoids
our
> common confusion between an element and a set of elements on the type level.
> Using "CcExtensionFlag" is a more appropriate then, too.

Done.

https://codereview.chromium.org/13483017/diff/1/test/cctest/cctest.h#newcode94
test/cctest/cctest.h:94: static void InitializeVM(int extensions =
NO_EXTENSIONS);
On 2013/04/09 07:26:28, Sven Panne wrote:
> Use EnumSet<CcTestExtensionFlag> (or perhaps a typedef of it) as a parameter.

Done.

https://codereview.chromium.org/13483017/diff/1/test/cctest/test-assembler-mi...
File test/cctest/test-assembler-mips.cc (right):

https://codereview.chromium.org/13483017/diff/1/test/cctest/test-assembler-mi...
test/cctest/test-assembler-mips.cc:47: #define __ assm.
On 2013/04/09 07:26:28, Sven Panne wrote:
> If it is really OK to remove the FLAG_disable_native_files line here, we
should
> probably nuke this flag.

I am not sure if it is really OK, I removed it and tests run through, so I
assumed it's a leftover from the original ports when MIPS couldn't compile the
builtins yet. As for removing the flag, I think it's better to leave it in for
other ports.

[Sven Panne, 2013-04-10 08:08:23]

lgtm

[Michael Starzinger, 2013-04-10 08:30:01]

Committed patchset #3 manually as r14199 (presubmit successful).