Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Side by Side Diff: test/cctest/cctest.cc

Issue 13483017: Unify the way cctest initalizes the VM for each test case. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed presubmit errors. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/cctest.h ('k') | test/cctest/test-assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 char *extension = strrchr(basename, '.'); 50 char *extension = strrchr(basename, '.');
51 if (extension) *extension = 0; 51 if (extension) *extension = 0;
52 // Install this test in the list of tests 52 // Install this test in the list of tests
53 file_ = basename; 53 file_ = basename;
54 enabled_ = enabled; 54 enabled_ = enabled;
55 prev_ = last_; 55 prev_ = last_;
56 last_ = this; 56 last_ = this;
57 } 57 }
58 58
59 59
60 v8::Persistent<v8::Context> CcTest::context_;
61
62
63 void CcTest::InitializeVM(CcTestExtensionFlags extensions) {
64 const char* extension_names[kMaxExtensions];
65 int extension_count = 0;
66 #define CHECK_EXTENSION_FLAG(Name, Id) \
67 if (extensions.Contains(Name##_ID)) extension_names[extension_count++] = Id;
68 EXTENSION_LIST(CHECK_EXTENSION_FLAG)
69 #undef CHECK_EXTENSION_FLAG
70 if (context_.IsEmpty()) {
71 v8::ExtensionConfiguration config(extension_count, extension_names);
72 context_ = v8::Context::New(&config);
73 }
74 context_->Enter();
75 }
76
77
60 static void PrintTestList(CcTest* current) { 78 static void PrintTestList(CcTest* current) {
61 if (current == NULL) return; 79 if (current == NULL) return;
62 PrintTestList(current->prev()); 80 PrintTestList(current->prev());
63 if (current->dependency() != NULL) { 81 if (current->dependency() != NULL) {
64 printf("%s/%s<%s\n", 82 printf("%s/%s<%s\n",
65 current->file(), current->name(), current->dependency()); 83 current->file(), current->name(), current->dependency());
66 } else { 84 } else {
67 printf("%s/%s<\n", current->file(), current->name()); 85 printf("%s/%s<\n", current->file(), current->name());
68 } 86 }
69 } 87 }
70 88
71 89
72 v8::Isolate* CcTest::default_isolate_; 90 v8::Isolate* CcTest::default_isolate_;
73 91
92
74 int main(int argc, char* argv[]) { 93 int main(int argc, char* argv[]) {
75 v8::internal::FlagList::SetFlagsFromCommandLine(&argc, argv, true); 94 v8::internal::FlagList::SetFlagsFromCommandLine(&argc, argv, true);
76 CcTest::set_default_isolate(v8::Isolate::GetCurrent()); 95 CcTest::set_default_isolate(v8::Isolate::GetCurrent());
77 CHECK(CcTest::default_isolate() != NULL); 96 CHECK(CcTest::default_isolate() != NULL);
78 int tests_run = 0; 97 int tests_run = 0;
79 bool print_run_count = true; 98 bool print_run_count = true;
80 for (int i = 1; i < argc; i++) { 99 for (int i = 1; i < argc; i++) {
81 char* arg = argv[i]; 100 char* arg = argv[i];
82 if (strcmp(arg, "--list") == 0) { 101 if (strcmp(arg, "--list") == 0) {
83 PrintTestList(CcTest::last()); 102 PrintTestList(CcTest::last());
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 } 140 }
122 } 141 }
123 if (print_run_count && tests_run != 1) 142 if (print_run_count && tests_run != 1)
124 printf("Ran %i tests.\n", tests_run); 143 printf("Ran %i tests.\n", tests_run);
125 v8::V8::Dispose(); 144 v8::V8::Dispose();
126 return 0; 145 return 0;
127 } 146 }
128 147
129 RegisterThreadedTest *RegisterThreadedTest::first_ = NULL; 148 RegisterThreadedTest *RegisterThreadedTest::first_ = NULL;
130 int RegisterThreadedTest::count_ = 0; 149 int RegisterThreadedTest::count_ = 0;
OLDNEW
« no previous file with comments | « test/cctest/cctest.h ('k') | test/cctest/test-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698