Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2080)

Unified Diff: tools/mb/mb_config.pyl

Issue 1348153003: Reland "Remove the 'gyp_config' concept from MB." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix win32 test on non-win32 platform Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/mb/mb.py ('k') | tools/mb/mb_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb_config.pyl
diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
index a233b2248fd826f5e2637a1bbe81d47b01d7ec1f..f4c03618daa85bbf947e0b4e73bf3cd229392ba9 100644
--- a/tools/mb/mb_config.pyl
+++ b/tools/mb/mb_config.pyl
@@ -159,7 +159,6 @@
'debug': {
'gn_args': 'is_debug=true',
- 'gyp_config': 'Debug',
},
'debug_bot': {
@@ -254,12 +253,10 @@
'official': {
'gn_args': 'is_chrome_branded is_official_build=true is_debug=false is_component_build=false',
'gyp_defines': 'branding="Chrome" buildtype="Official" component=static_library',
- 'gyp_config': 'Release',
},
'release': {
'gn_args': 'is_debug=false',
- 'gyp_config': 'Release',
},
'release_bot': {
« no previous file with comments | « tools/mb/mb.py ('k') | tools/mb/mb_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698