Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1348073002: [turbofan] Get rid of type lower bounds. (Closed)

Created:
5 years, 3 months ago by Jarin
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com, neis
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Get rid of type lower bounds. Committed: https://crrev.com/92903d0a1998aa4774c5b6ae61edc36187006216 Cr-Commit-Position: refs/heads/master@{#30764}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+494 lines, -738 lines) Patch
M src/compiler/change-lowering.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 3 chunks +10 lines, -17 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-type-feedback-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 19 chunks +23 lines, -27 lines 0 comments Download
M src/compiler/node.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/node.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/node-properties.h View 1 chunk +8 lines, -13 lines 0 comments Download
M src/compiler/osr.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/representation-change.h View 6 chunks +8 lines, -6 lines 0 comments Download
M src/compiler/schedule.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 12 chunks +13 lines, -13 lines 0 comments Download
M src/compiler/typer.cc View 1 18 chunks +365 lines, -589 lines 0 comments Download
M src/compiler/verifier.cc View 1 6 chunks +13 lines, -16 lines 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 8 chunks +15 lines, -15 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/typer-unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Jarin
Could you take a look, please?
5 years, 3 months ago (2015-09-16 10:48:34 UTC) #1
Jarin
Could you take a look, please?
5 years, 3 months ago (2015-09-16 10:49:04 UTC) #3
Benedikt Meurer
Dead should be dead! LGTM!
5 years, 3 months ago (2015-09-16 10:54:02 UTC) #5
rossberg
Looks okay to me, although I don't know what the non-Crank backup plan is. :)
5 years, 3 months ago (2015-09-16 10:58:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348073002/20001
5 years, 3 months ago (2015-09-16 11:31:38 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-16 11:55:32 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 11:55:48 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92903d0a1998aa4774c5b6ae61edc36187006216
Cr-Commit-Position: refs/heads/master@{#30764}

Powered by Google App Engine
This is Rietveld 408576698