Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: src/compiler/node-properties.h

Issue 1348073002: [turbofan] Get rid of type lower bounds. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/node.cc ('k') | src/compiler/osr.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/node-properties.h
diff --git a/src/compiler/node-properties.h b/src/compiler/node-properties.h
index 6d11f6cfcce507ce8b1b47a8066d2ceacab23d05..4fa160da36cb4a0caf68f9f2c6ce17641600b598 100644
--- a/src/compiler/node-properties.h
+++ b/src/compiler/node-properties.h
@@ -108,23 +108,18 @@ class NodeProperties final {
// ---------------------------------------------------------------------------
- // Type Bounds.
+ // Type.
- static bool IsTyped(Node* node) {
- Bounds const bounds = node->bounds();
- DCHECK(!bounds.lower == !bounds.upper);
- return bounds.upper;
- }
- static Bounds GetBounds(Node* node) {
+ static bool IsTyped(Node* node) { return node->type() != nullptr; }
+ static Type* GetType(Node* node) {
DCHECK(IsTyped(node));
- return node->bounds();
+ return node->type();
}
- static void SetBounds(Node* node, Bounds bounds) {
- DCHECK_NOT_NULL(bounds.lower);
- DCHECK_NOT_NULL(bounds.upper);
- node->set_bounds(bounds);
+ static void SetType(Node* node, Type* type) {
+ DCHECK_NOT_NULL(type);
+ node->set_type(type);
}
- static void RemoveBounds(Node* node) { node->set_bounds(Bounds()); }
+ static void RemoveType(Node* node) { node->set_type(nullptr); }
static bool AllValueInputsAreTyped(Node* node);
private:
« no previous file with comments | « src/compiler/node.cc ('k') | src/compiler/osr.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698