Issue 1347683002: Subzero: Fix off-by-one asserts in intrinsic info lookup routines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1347683002: Subzero: Fix off-by-one asserts in intrinsic info lookup routines. (Closed)

Created:
5 years, 3 months ago by Jim Stichnoth

Modified:
5 years, 3 months ago

Reviewers:
Karl, ascull, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Fix off-by-one asserts in intrinsic info lookup routines. It turns out that getNumArgs() and getReturnType() were never actually called except to print errors, so this bug was never encountered until now. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4315 R=ascull@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=92b31446ca8c777d296a00d05c2e507a2df5fddf

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	src/IceIntrinsics.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/IceIntrinsics.cpp	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

5 years, 3 months ago (2015-09-15 17:10:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
92b31446ca8c777d296a00d05c2e507a2df5fddf (presubmit successful).