Subzero: Fix off-by-one asserts in intrinsic info lookup routines.

src/IceIntrinsics.cpp

 //===- subzero/src/IceIntrinsics.cpp - Functions related to intrinsics ----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 297 matching lines @@
     case MemoryOrderAcquire:
     case MemoryOrderAcquireRelease:
       return false;
     default:
       return true;
     }
   }
 }
 
 Intrinsics::ValidateCallValue
-Intrinsics::FullIntrinsicInfo::validateCall(const Ice::InstCall *Call,
+Intrinsics::FullIntrinsicInfo::validateCall(const InstCall *Call,
                                             SizeT &ArgIndex) const {
   assert(NumTypes >= 1);
   Variable *Result = Call->getDest();
   if (Result == nullptr) {
-    if (Signature[0] != Ice::IceType_void)
+    if (getReturnType() != IceType_void)
       return Intrinsics::BadReturnType;
-  } else if (Signature[0] != Result->getType()) {
+  } else if (getReturnType() != Result->getType()) {
     return Intrinsics::BadReturnType;
   }
-  if (Call->getNumArgs() + 1 != NumTypes) {
+  if (Call->getNumArgs() != getNumArgs()) {
     return Intrinsics::WrongNumOfArgs;
   }
   for (size_t i = 1; i < NumTypes; ++i) {
     if (Call->getArg(i - 1)->getType() != Signature[i]) {
       ArgIndex = i;
       return Intrinsics::WrongCallArgType;
     }
   }
   return Intrinsics::IsValidCall;
 }
 
 Type Intrinsics::FullIntrinsicInfo::getArgType(SizeT Index) const {
   assert(NumTypes > 1);
   assert(Index + 1 < NumTypes);
   return Signature[Index + 1];
 }
 
 } // end of namespace Ice