Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1347413002: WebRTC: Rename trybots and add compile-only configs. (Closed)

Created:
5 years, 3 months ago by kjellander_chromium
Modified:
5 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/remotes/origin/master
Project:
build
Visibility:
Public.

Description

WebRTC: Rename trybots and add compile-only configs. - Rename Debug trybots to use _dbg suffix. - Add compile-only bots. - Add missing x64 Debug configurations (that will not be run by default). This should improve our flexibility and allows to run compile-only trybots for Debug configuration, which should reduce the CQ load a bit. Summary of changes: New bots: win_compile_dbg win_compile_rel win_compile_x64_dbg win_compile_x64_rel mac_compile_dbg mac_compile_rel mac_compile_x64_dbg mac_compile_x64_rel linux_compile_dbg linux_compile_rel android_compile_dbg android_compile_rel android_compile_arm64_dbg android_compile_arm64_rel New debug configurations (were missing): mac_x64_dbg win_x64_dbg Renamed trybots for consistency: win -> win_dbg win_x64_gn -> win_x64_gn_dbg mac -> mac_dbg mac_x64_gn -> mac_x64_gn_dbg ios -> ios_dbg ios_arm64 -> ios_arm64_dbg ios32_sim -> ios32_sim_dbg ios64_sim -> ios64_sim_dbg linux -> linux_dbg linux_gn -> linux_gn_dbg android -> android_dbg android_clang -> android_clang_dbg android_gn -> android_gn_dbg R=machenbach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=296806

Patch Set 1 #

Patch Set 2 : Fixed one copy-paste mistake #

Total comments: 5

Patch Set 3 : Rebased #

Patch Set 4 : Regenerated expectations #

Patch Set 5 : Remove masters/master.chromiumos.tryserver/config.current.txt #

Patch Set 6 : Remove scripts/slave/recipes/android/builder.expected/chromium_fyi_Android_x64_Builder__dbg__fail_c… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+745 lines, -4686 lines) Patch
M masters/master.tryserver.webrtc/master.cfg View 1 2 1 chunk +29 lines, -14 lines 0 comments Download
M masters/master.tryserver.webrtc/slaves.cfg View 1 2 4 chunks +32 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/webrtc/builders.py View 1 2 15 chunks +166 lines, -13 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.py View 1 chunk +1 line, -1 line 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android.json View 1 2 1 chunk +0 lines, -557 lines 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_clang.json View 1 chunk +0 lines, -151 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_clang_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_dbg.json View 4 chunks +11 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_rel.json View 4 chunks +3 lines, -18 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_dbg.json View 4 chunks +2 lines, -17 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_rel.json View 4 chunks +2 lines, -17 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gn.json View 1 chunk +0 lines, -143 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gn_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios.json View 1 chunk +0 lines, -127 lines 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios32_sim.json View 1 chunk +0 lines, -127 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios32_sim_dbg.json View 2 chunks +2 lines, -2 lines 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios64_sim.json View 1 chunk +0 lines, -127 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios64_sim_dbg.json View 2 chunks +2 lines, -2 lines 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios_arm64.json View 1 chunk +0 lines, -127 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios_arm64_dbg.json View 2 chunks +2 lines, -2 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios_dbg.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux.json View 1 chunk +0 lines, -465 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_dbg.json View 4 chunks +2 lines, -16 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel.json View 4 chunks +2 lines, -16 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json View 17 chunks +47 lines, -47 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg_legacy_svn_patch.json View 17 chunks +47 lines, -47 lines 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gn.json View 1 chunk +0 lines, -119 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gn_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_legacy_svn_patch.json View 1 chunk +0 lines, -461 lines 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac.json View 1 chunk +0 lines, -455 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_dbg.json View 3 chunks +3 lines, -17 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_rel.json View 1 4 chunks +5 lines, -7 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_x64_dbg.json View 3 chunks +2 lines, -16 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_x64_rel.json View 1 3 chunks +2 lines, -16 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json View 17 chunks +48 lines, -70 lines 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_x64.json View 1 chunk +0 lines, -477 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_x64_dbg.json View 3 chunks +152 lines, -140 lines 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_x64_gn.json View 1 chunk +0 lines, -139 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_x64_gn_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
D scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win.json View 1 chunk +0 lines, -450 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json View 4 chunks +4 lines, -18 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json View 1 4 chunks +4 lines, -18 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json View 4 chunks +2 lines, -16 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_rel.json View 1 4 chunks +2 lines, -16 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json View 16 chunks +46 lines, -46 lines 0 comments Download
A + scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json View 20 chunks +117 lines, -132 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
kjellander_chromium
Looks huge but it isn't that bad :) https://codereview.chromium.org/1347413002/diff/20001/masters/master.tryserver.webrtc/slaves.cfg File masters/master.tryserver.webrtc/slaves.cfg (left): https://codereview.chromium.org/1347413002/diff/20001/masters/master.tryserver.webrtc/slaves.cfg#oldcode165 masters/master.tryserver.webrtc/slaves.cfg:165: 'hostname': ...
5 years, 3 months ago (2015-09-17 13:12:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347413002/20001
5 years, 3 months ago (2015-09-21 14:09:45 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/1832)
5 years, 3 months ago (2015-09-21 14:11:27 UTC) #6
Michael Achenbach
LGTM if presubmit passes - sorry for the late response. This one fell through the ...
5 years, 3 months ago (2015-09-21 14:18:58 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347413002/40001
5 years, 3 months ago (2015-09-21 14:25:46 UTC) #9
kjellander_chromium
Replied.. I'll probably update the tryserver manually for this one, so I can rename a ...
5 years, 3 months ago (2015-09-21 14:30:06 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/1836)
5 years, 3 months ago (2015-09-21 14:51:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347413002/40001
5 years, 3 months ago (2015-09-22 05:54:01 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/1864)
5 years, 3 months ago (2015-09-22 06:00:28 UTC) #17
kjellander_chromium
5 years, 3 months ago (2015-09-22 06:07:57 UTC) #18
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as 296806.

Powered by Google App Engine
This is Rietveld 408576698