Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1347373003: Revert of Add a dummy variable to ResourceMsg_DataReceived. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@ipc_revert2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a dummy variable to ResourceMsg_DataReceived. (patchset #4 id:60001 of https://codereview.chromium.org/1346923008/ ) Reason for revert: This CL was only intended to be a part of one canary release. Original issue's description: > content: Add a dummy variable to ResourceMsg_DataReceived. > > I suspect that this will expose a crash for a small number of Windows canary > users. This CL is only intended to be landed for one day. > > BUG=527588 > > Committed: https://crrev.com/a59c6e37a4cc9f01ab0a8fffc79004875a8b0617 > Cr-Commit-Position: refs/heads/master@{#349830} TBR=avi@chromium.org,tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=527588 Committed: https://crrev.com/9064a2524f743be9eaafd39c442fa2391f657a92 Cr-Commit-Position: refs/heads/master@{#349881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -29 lines) Patch
M content/browser/loader/async_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/child/resource_dispatcher.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/threaded_data_provider.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +2 lines, -5 lines 0 comments Download
M content/common/resource_messages.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of Add a dummy variable to ResourceMsg_DataReceived.
5 years, 3 months ago (2015-09-20 22:29:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347373003/1
5 years, 3 months ago (2015-09-20 22:29:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-20 22:30:12 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-20 22:30:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9064a2524f743be9eaafd39c442fa2391f657a92
Cr-Commit-Position: refs/heads/master@{#349881}

Powered by Google App Engine
This is Rietveld 408576698