Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: content/child/threaded_data_provider.cc

Issue 1347373003: Revert of Add a dummy variable to ResourceMsg_DataReceived. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ipc_revert2
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/resource_dispatcher_unittest.cc ('k') | content/common/resource_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/threaded_data_provider.cc
diff --git a/content/child/threaded_data_provider.cc b/content/child/threaded_data_provider.cc
index 11fb971fc92f06ed0a25972581148c81d375cbc1..f65f8dcf96d2259d9214e09710fb2a534d14ead2 100644
--- a/content/child/threaded_data_provider.cc
+++ b/content/child/threaded_data_provider.cc
@@ -38,12 +38,7 @@
private:
~DataProviderMessageFilter() override {}
- // TODO(erikchen): This dummy variable is temporary and is only intended to be
- // present for one Canary release. http://crbug.com/527588.
- void OnReceivedData(int request_id,
- int /* dummy variable */,
- int data_offset,
- int data_length,
+ void OnReceivedData(int request_id, int data_offset, int data_length,
int encoded_data_length);
const scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
@@ -105,8 +100,8 @@
if (request_id == request_id_) {
ResourceMsg_DataReceived::Schema::Param arg;
if (ResourceMsg_DataReceived::Read(&message, &arg)) {
- OnReceivedData(base::get<0>(arg), base::get<1>(arg), base::get<2>(arg),
- base::get<3>(arg), base::get<4>(arg));
+ OnReceivedData(base::get<0>(arg), base::get<1>(arg),
+ base::get<2>(arg), base::get<3>(arg));
return true;
}
}
@@ -115,7 +110,6 @@
}
void DataProviderMessageFilter::OnReceivedData(int request_id,
- int /* dummy variable */,
int data_offset,
int data_length,
int encoded_data_length) {
« no previous file with comments | « content/child/resource_dispatcher_unittest.cc ('k') | content/common/resource_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698