Issue 134733007: Fix for potential issue related to replacing CheckMaps with values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134733007: Fix for potential issue related to replacing CheckMaps with values. (Closed)

Created:
6 years, 11 months ago by Igor Sheludko

Modified:
6 years, 10 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix for potential issue related to replacing CheckMaps with values. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18887

Patch Set 2 : Review notes applied #

Patch Set 3 : Rebasing on r18885. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -20 lines)			Patch
M	src/hydrogen.cc	View	1 2	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/hydrogen-check-elimination.cc	View	1 2	4 chunks	+46 lines, -19 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

titzer

lgtm other one comment https://codereview.chromium.org/134733007/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/134733007/diff/1/src/hydrogen.cc#newcode3922 src/hydrogen.cc:3922: instruction->DeleteAndReplaceWith(instruction->ActualValue()); Not sure this is ...

6 years, 11 months ago (2014-01-23 18:34:46 UTC) #1

Igor Sheludko

https://codereview.chromium.org/134733007/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/134733007/diff/1/src/hydrogen.cc#newcode3922 src/hydrogen.cc:3922: instruction->DeleteAndReplaceWith(instruction->ActualValue()); On 2014/01/23 18:34:46, titzer wrote: > Not sure ...

6 years, 10 months ago (2014-01-28 17:45:05 UTC) #2