Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: src/hydrogen.cc

Issue 134733007: Fix for potential issue related to replacing CheckMaps with values. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebasing on r18885. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen-check-elimination.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3915 matching lines...) Expand 10 before | Expand all | Expand 10 after
3926 3926
3927 #ifdef DEBUG 3927 #ifdef DEBUG
3928 for (int i = 0; i < block->phis()->length(); i++) { 3928 for (int i = 0; i < block->phis()->length(); i++) {
3929 HPhi* phi = block->phis()->at(i); 3929 HPhi* phi = block->phis()->at(i);
3930 ASSERT(phi->ActualValue() == phi); 3930 ASSERT(phi->ActualValue() == phi);
3931 } 3931 }
3932 #endif 3932 #endif
3933 3933
3934 for (HInstructionIterator it(block); !it.Done(); it.Advance()) { 3934 for (HInstructionIterator it(block); !it.Done(); it.Advance()) {
3935 HInstruction* instruction = it.Current(); 3935 HInstruction* instruction = it.Current();
3936 if (instruction->ActualValue() != instruction) { 3936 if (instruction->ActualValue() == instruction) continue;
3937 if (instruction->CheckFlag(HValue::kIsDead)) {
3938 // The instruction was marked as deleted but left in the graph
3939 // as a control flow dependency point for subsequent
3940 // instructions.
3941 instruction->DeleteAndReplaceWith(instruction->ActualValue());
3942 } else {
3937 ASSERT(instruction->IsInformativeDefinition()); 3943 ASSERT(instruction->IsInformativeDefinition());
3938 if (instruction->IsPurelyInformativeDefinition()) { 3944 if (instruction->IsPurelyInformativeDefinition()) {
3939 instruction->DeleteAndReplaceWith(instruction->RedefinedOperand()); 3945 instruction->DeleteAndReplaceWith(instruction->RedefinedOperand());
3940 } else { 3946 } else {
3941 instruction->ReplaceAllUsesWith(instruction->ActualValue()); 3947 instruction->ReplaceAllUsesWith(instruction->ActualValue());
3942 } 3948 }
3943 } 3949 }
3944 } 3950 }
3945 } 3951 }
3946 } 3952 }
(...skipping 7171 matching lines...) Expand 10 before | Expand all | Expand 10 after
11118 if (ShouldProduceTraceOutput()) { 11124 if (ShouldProduceTraceOutput()) {
11119 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 11125 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
11120 } 11126 }
11121 11127
11122 #ifdef DEBUG 11128 #ifdef DEBUG
11123 graph_->Verify(false); // No full verify. 11129 graph_->Verify(false); // No full verify.
11124 #endif 11130 #endif
11125 } 11131 }
11126 11132
11127 } } // namespace v8::internal 11133 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-check-elimination.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698