Extend unittest to test follow-module behavior of find_dependencies.py

Extend unittest to test follow-module behavior of find_dependencies.py

Problem origin: https://crbug.com/527836
Fixed: https://codereview.chromium.org/1306953007

BUG=531562
Committed: https://crrev.com/cada8949e01b878c356b85f704a819b048dd2f38
Cr-Commit-Position: refs/heads/master@{#350582}

[alexanderk, 2015-09-21 10:31:18]

alexanderk@opera.com changed reviewers:
+ aiolos@chromium.org, dtu@chromium.org, eakuefner@chromium.org,
nednguyen@google.org

[alexanderk, 2015-09-21 10:31:51]

alexanderk@opera.com changed reviewers:
+ nednguyen@google.com
- nednguyen@google.org

[nednguyen, 2015-09-22 15:11:41]

Awesome! Thanks a lot for adding these tests. 
Just want to make sure that you verify the test fails without the test?

https://codereview.chromium.org/1347283006/diff/1/tools/telemetry/telemetry/i...
File tools/telemetry/telemetry/internal/util/find_dependencies_unittest.py
(right):

https://codereview.chromium.org/1347283006/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/util/find_dependencies_unittest.py:20:
bone_object_path = os.path.join(bone_module_path, 'bone_object.py')
Can you factor these extra tests to a different test method? Ideally, each test
method should test a single case to make it easier to fix tests when things
break.

[alexanderk, 2015-09-24 13:42:29]

On 2015/09/22 15:11:41, nednguyen wrote:
> Awesome! Thanks a lot for adding these tests. 
> Just want to make sure that you verify the test fails without the test?

Of course I verified :)

>
https://codereview.chromium.org/1347283006/diff/1/tools/telemetry/telemetry/i...
> File tools/telemetry/telemetry/internal/util/find_dependencies_unittest.py
> (right):
> 
>
https://codereview.chromium.org/1347283006/diff/1/tools/telemetry/telemetry/i...
> tools/telemetry/telemetry/internal/util/find_dependencies_unittest.py:20:
> bone_object_path = os.path.join(bone_module_path, 'bone_object.py')
> Can you factor these extra tests to a different test method? Ideally, each
test
> method should test a single case to make it easier to fix tests when things
> break.

OK, agree, I just wasnt sure - seems it should have been the first case to test.

[nednguyen, 2015-09-24 15:30:56]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2015-09-24 15:30:56]

lgtm

[commit-bot: I haz the power, 2015-09-24 15:32:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1347283006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1347283006/20001

[commit-bot: I haz the power, 2015-09-24 16:54:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-24 16:55:08]

Patchset 2 (id:??) landed as
https://crrev.com/cada8949e01b878c356b85f704a819b048dd2f38
Cr-Commit-Position: refs/heads/master@{#350582}