Extend unittest to test follow-module behavior of find_dependencies.py

tools/telemetry/telemetry/internal/util/find_dependencies_unittest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import unittest
 
 from telemetry.core import util
 from telemetry.internal.util import find_dependencies
 
 
 class FindDependenciesTest(unittest.TestCase):
   def testFindPythonDependencies(self):
-    dog_object_path = os.path.join(
+    dog_module_path = os.path.join(
         util.GetUnittestDataDir(),
-        'dependency_test_dir', 'dog', 'dog', 'dog_object.py')
+        'dependency_test_dir', 'dog', 'dog')
+    dog_object_path = os.path.join(dog_module_path, 'dog_object.py')
+    bone_module_path = os.path.join(dog_module_path, 'bone')
+    bone_module_init_path = os.path.join(bone_module_path, '__init__.py')
+    bone_object_path = os.path.join(bone_module_path, 'bone_object.py')

[nednguyen, 2015/09/22 15:11:41]

Can you factor these extra tests to a different test method? Ideally, each test
method should test a single case to make it easier to fix tests when things
break.

     cat_module_path = os.path.join(
         util.GetUnittestDataDir(),
         'dependency_test_dir', 'other_animals', 'cat', 'cat')
     cat_module_init_path = os.path.join(cat_module_path, '__init__.py')
     cat_object_path = os.path.join(cat_module_path, 'cat_object.py')
     self.assertEquals(
       set(p for p in find_dependencies.FindPythonDependencies(dog_object_path)),
-      {dog_object_path, cat_module_path, cat_module_init_path, cat_object_path})
+      {dog_object_path,
+          bone_module_path, bone_module_init_path, bone_object_path,
+          cat_module_path, cat_module_init_path, cat_object_path})