Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1347263003: Pretenure builtin typed arrays. (Closed)

Created:
5 years, 3 months ago by bnoordhuis
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pretenure builtin typed arrays. Typed arrays from the snapshot start out in the young space but they all seem to end up in the old space sooner or later anyway. Let's expedite that by allocating them in the old space right away. Committed: https://crrev.com/bfce6778662592b2838520ede8fbb7147da77e09 Cr-Commit-Position: refs/heads/master@{#30804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -42 lines) Patch
M src/bootstrapper.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M src/factory.h View 1 chunk +10 lines, -5 lines 0 comments Download
M src/factory.cc View 6 chunks +36 lines, -31 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/mjsunit/builtins.js View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
bnoordhuis
5 years, 3 months ago (2015-09-16 23:28:41 UTC) #2
Michael Achenbach
Please find a better owner for this.
5 years, 3 months ago (2015-09-17 07:49:17 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347263003/1
5 years, 3 months ago (2015-09-17 13:36:51 UTC) #6
jochen (gone - plz use gerrit)
+michael fyi lgtm
5 years, 3 months ago (2015-09-17 13:59:55 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 14:02:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347263003/1
5 years, 3 months ago (2015-09-17 14:30:58 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5887)
5 years, 3 months ago (2015-09-17 14:32:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347263003/1
5 years, 3 months ago (2015-09-17 14:46:11 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 14:47:43 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 14:48:04 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfce6778662592b2838520ede8fbb7147da77e09
Cr-Commit-Position: refs/heads/master@{#30804}

Powered by Google App Engine
This is Rietveld 408576698