Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1347263002: Revert of Cross-repo recipe package system. (Closed)

Created:
5 years, 3 months ago by luqui
Modified:
5 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews, kjellander-cc_chromium.org, martiniss, stip+watch_chromium.org, ghost stip (do not use)
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Cross-repo recipe package system. (patchset #17 id:320001 of https://codereview.chromium.org/1241323004/ ) Reason for revert: World exploded Original issue's description: > Cross-repo recipe package system. > > This rolls the package system created in https://codereview.chromium.org/1344583003/ into tools/build, moving core modules to the engine. See in particular the new entry point scripts/slave/recipes.py and the recipes configuration infra/config/recipes.cfg. > > Internal changes: https://chromereviews.googleplex.com/227207013/ > > TBR for uniform chromium_tests changes. > > BUG=459840 > TBR=phajdan.jr@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296718 TBR=iannucci@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459840 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10425 lines, -374 lines) Patch
M .gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M infra/config/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D infra/config/recipes.cfg View 1 chunk +0 lines, -9 lines 0 comments Download
M scripts/slave/annotated_run.py View 3 chunks +7 lines, -44 lines 0 comments Download
M scripts/slave/bot_update.py View 3 chunks +3 lines, -24 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/api.py View 4 chunks +19 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/builders.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/cronet/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/cronet/example.py View 1 chunk +1 line, -1 line 0 comments Download
A scripts/slave/recipe_modules/example/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/example/api.py View 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/file/__init__.py View 1 chunk +5 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/file/example.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/file/test_api.py View 1 chunk +26 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/gatekeeper/test_api.py View 1 chunk +6 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/generator_script/__init__.py View 1 chunk +6 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/generator_script/api.py View 1 chunk +84 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/generator_script/example.py View 1 chunk +67 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/generator_script/example.expected/always_run.json View 1 chunk +77 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/generator_script/example.expected/basic.json View 1 chunk +30 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/generator_script/example.expected/basic_python.json View 1 chunk +35 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/generator_script/example.expected/presentation.json View 1 chunk +38 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/generator_script/test_api.py View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/git/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/git/api.py View 2 chunks +1 line, -2 lines 0 comments Download
M scripts/slave/recipe_modules/gpu/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py View 1 chunk +1 line, -1 line 0 comments Download
A scripts/slave/recipe_modules/itertools/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A scripts/slave/recipe_modules/itertools/api.py View 1 chunk +11 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/json/__init__.py View 1 chunk +5 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/json/api.py View 1 chunk +122 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/json/example.py View 1 chunk +49 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/json/example.expected/basic.json View 1 chunk +63 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/json/test_api.py View 1 chunk +15 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/math_utils/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A scripts/slave/recipe_modules/math_utils/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A scripts/slave/recipe_modules/math_utils/api.py View 1 chunk +357 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/path/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/path/api.py View 1 chunk +238 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/path/config.py View 1 chunk +47 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/path/example.py View 1 chunk +26 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/path/example.expected/linux.json View 1 chunk +18 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/path/example.expected/mac.json View 1 chunk +18 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/path/example.expected/win.json View 1 chunk +18 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/path/test_api.py View 1 chunk +12 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/platform/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A scripts/slave/recipe_modules/platform/api.py View 1 chunk +92 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/platform/test_api.py View 1 chunk +18 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/properties/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A scripts/slave/recipe_modules/properties/api.py View 1 chunk +48 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/properties/example.py View 1 chunk +30 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/properties/example.expected/basic.json View 1 chunk +18 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/properties/example.expected/dicts.json View 1 chunk +18 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/properties/example.expected/lists.json View 1 chunk +18 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/properties/test_api.py View 1 chunk +71 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/python/__init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/python/api.py View 1 chunk +55 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/python/example.py View 1 chunk +27 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/python/example.expected/basic.json View 1 chunk +29 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/raw_io/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
A scripts/slave/recipe_modules/raw_io/api.py View 1 chunk +159 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/raw_io/example.py View 1 chunk +66 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/raw_io/example.expected/basic.json View 1 chunk +66 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/raw_io/test_api.py View 1 chunk +21 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/skia/resources/run_binary_size_analysis.py View 1 chunk +1 line, -1 line 0 comments Download
A scripts/slave/recipe_modules/step/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/step/api.py View 1 chunk +150 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/step/config.py View 1 chunk +58 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/step/example.py View 1 chunk +115 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/step/example.expected/basic.json View 1 chunk +114 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/step/example.expected/defer_results.json View 1 chunk +95 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/step/example.expected/exceptional.json View 1 chunk +79 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/step/example.expected/infra_failure.json View 1 chunk +118 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/step/example.expected/invalid_access.json View 1 chunk +124 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/swarming/api.py View 1 chunk +1 line, -1 line 0 comments Download
A scripts/slave/recipe_modules/time/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A scripts/slave/recipe_modules/time/api.py View 1 chunk +33 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/time/example.py View 1 chunk +18 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/time/example.expected/defaults.json View 1 chunk +10 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/time/example.expected/seed_and_step.json View 1 chunk +10 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/time/test_api.py View 1 chunk +16 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/uuid/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A scripts/slave/recipe_modules/uuid/api.py View 1 chunk +16 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/uuid/example.py View 1 chunk +17 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/uuid/example.expected/basic.json View 1 chunk +10 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/v8/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/v8/builders.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/webrtc/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/webrtc/builders.py View 1 chunk +1 line, -1 line 0 comments Download
A scripts/slave/recipe_universe.py View 1 chunk +27 lines, -0 lines 0 comments Download
D scripts/slave/recipes.py View 1 chunk +0 lines, -135 lines 0 comments Download
M scripts/slave/recipes/android/appurify.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.py View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android_webview_aosp_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android_webview_shell_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_downstream.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.py View 3 chunks +1 line, -18 lines 0 comments Download
M scripts/slave/recipes/chromium_codesearch.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_gn.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_gn_upload.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_isolate.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_mojo.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_pgo.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 3 chunks +2 lines, -9 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.py View 4 chunks +4 lines, -5 lines 0 comments Download
M scripts/slave/recipes/cronet.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dartium_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gatekeeper.py View 1 chunk +14 lines, -0 lines 0 comments Download
A scripts/slave/recipes/gatekeeper.expected/real.json View 1 chunk +423 lines, -0 lines 0 comments Download
M scripts/slave/recipes/legion/legion.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libvpx/android_unittests.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ozone_ecs.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/swarming/deterministic_build.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/continuous.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8/auto_roll_v8_deps.py View 1 chunk +1 line, -1 line 0 comments Download
D scripts/slave/unittests/annotated_run_test.py View 1 chunk +0 lines, -24 lines 0 comments Download
M scripts/slave/unittests/recipe_lint_test.py View 2 chunks +7 lines, -9 lines 0 comments Download
M scripts/slave/unittests/recipe_simulation_test.py View 1 chunk +4 lines, -14 lines 0 comments Download
A scripts/tools/show_me_the_modules.py View 1 chunk +124 lines, -0 lines 0 comments Download
A scripts/tools/unittests/show_me_the_modules_test.py View 1 chunk +20 lines, -0 lines 0 comments Download
M tests/masters_recipes_test.py View 5 chunks +12 lines, -22 lines 0 comments Download
A third_party/infra/README View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/infra/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/infra/libs/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/infra/libs/infra_types/__init__.py View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/infra/libs/infra_types/infra_types.py View 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/infra/libs/infra_types/test/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/infra/libs/infra_types/test/infra_types_test.py View 1 chunk +85 lines, -0 lines 0 comments Download
A third_party/recipe_engine/README.md View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/recipe_engine/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/recipe_engine/config.py View 1 chunk +736 lines, -0 lines 0 comments Download
A third_party/recipe_engine/config_types.py View 1 chunk +164 lines, -0 lines 0 comments Download
A third_party/recipe_engine/doc/user_guide.md View 1 chunk +625 lines, -0 lines 0 comments Download
A third_party/recipe_engine/expect_tests/__init__.py View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/recipe_engine/expect_tests/cover.py View 1 chunk +85 lines, -0 lines 0 comments Download
A third_party/recipe_engine/expect_tests/handle_debug.py View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/recipe_engine/expect_tests/handle_list.py View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/recipe_engine/expect_tests/handle_test.py View 1 chunk +153 lines, -0 lines 0 comments Download
A third_party/recipe_engine/expect_tests/handle_train.py View 1 chunk +148 lines, -0 lines 0 comments Download
A third_party/recipe_engine/expect_tests/main.py View 1 chunk +163 lines, -0 lines 0 comments Download
A third_party/recipe_engine/expect_tests/pipeline.py View 1 chunk +248 lines, -0 lines 0 comments Download
A third_party/recipe_engine/expect_tests/serialize.py View 1 chunk +127 lines, -0 lines 0 comments Download
A third_party/recipe_engine/expect_tests/type_definitions.py View 1 chunk +433 lines, -0 lines 0 comments Download
A third_party/recipe_engine/expect_tests/unittest_helper.py View 1 chunk +94 lines, -0 lines 0 comments Download
A third_party/recipe_engine/expect_tests/util.py View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/recipe_engine/field_composer.py View 1 chunk +86 lines, -0 lines 0 comments Download
A third_party/recipe_engine/lint_test.py View 1 chunk +70 lines, -0 lines 0 comments Download
A third_party/recipe_engine/loader.py View 1 chunk +460 lines, -0 lines 0 comments Download
A third_party/recipe_engine/main.py View 1 chunk +939 lines, -0 lines 0 comments Download
A third_party/recipe_engine/recipe_api.py View 1 chunk +525 lines, -0 lines 0 comments Download
A third_party/recipe_engine/recipe_test_api.py View 1 chunk +462 lines, -0 lines 0 comments Download
A third_party/recipe_engine/simulation_test.py View 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/recipe_engine/third_party/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/recipe_engine/third_party/annotator.py View 1 chunk +348 lines, -0 lines 0 comments Download
A third_party/recipe_engine/unittests/field_composer_test.py View 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/recipe_engine/unittests/properties_test.py View 1 chunk +102 lines, -0 lines 0 comments Download
A third_party/recipe_engine/util.py View 1 chunk +148 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
luqui
Created Revert of Cross-repo recipe package system.
5 years, 3 months ago (2015-09-16 21:10:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347263002/1
5 years, 3 months ago (2015-09-16 21:10:12 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 21:10:59 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296719

Powered by Google App Engine
This is Rietveld 408576698