Refactor DBusThreadManager to split away BT clients.

Refactor DBusThreadManager to split away BT clients.

To be able to reuse the bluetooth DBus clients on linux, we need to be able
to separate them out from DBusThreadManager and move them out of //chromeos.

This CL introduces no functional change but instead only refactors the code
so we now have a BluezDbusManager that handles a Bluetooth specific DBus
client bundle to create all the bluetooth related DBus clients. We will
be able to extend this code to add a Linux specific BluezDbusManager
implementation, allowing us to reuse all these DBus clients on Linux instead
of copy/pasting the code.

R=armansito@chromium.org, stevenjb@chromium.org
BUG=522663
Committed: https://crrev.com/5d3c8959a7aee861b6750fd734cad96bd24e1f9f
Cr-Commit-Position: refs/heads/master@{#351197}

[stevenjb, 2015-09-17 21:48:01]

Generally looks good, but we should avoid any implicit dependency on
src/chromeos and DBusThreadManager even in this initial CL.

https://codereview.chromium.org/1347193004/diff/1/chrome/browser/chromeos/chr...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

https://codereview.chromium.org/1347193004/diff/1/chrome/browser/chromeos/chr...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:174: // initialized.
See my other comments, but we should avoid this implicit dependency from the get
go.

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/BUILD.gn
File device/bluetooth/BUILD.gn (right):

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/BUILD.gn#n...
device/bluetooth/BUILD.gn:162: defines += [ "CHROMEOS_IMPLEMENTATION" ]
DEVICE_BLUETOOTH_IMPLEMENTATION

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/bluetooth.gyp
File device/bluetooth/bluetooth.gyp (right):

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/bluetooth....
device/bluetooth/bluetooth.gyp:134: 'CHROMEOS_IMPLEMENTATION',
DEVICE_BLUETOOTH_IMPLEMENTATION

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
File device/bluetooth/dbus/bluez_dbus_manager.cc (right):

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
device/bluetooth/dbus/bluez_dbus_manager.cc:10: #include
"chromeos/chromeos_switches.h"
Not needed

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
device/bluetooth/dbus/bluez_dbus_manager.cc:46: return
chromeos::DBusThreadManager::Get()->GetSystemBus();
Rather than depending on DBusThreadManager (which will only exist on chromeos),
pass dbus::Bus* to DBusThreadManager::Initialize(). I realize that this is a
"not functional changes" CL, but I would rather skip adding the chromeos/
dependency here entirely, and it's a pretty minor change.

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
device/bluetooth/dbus/bluez_dbus_manager.cc:134:
chromeos::DBusClientBundle::BLUETOOTH);
Pass |use_stub| here explicitly instead.

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
File device/bluetooth/dbus/bluez_dbus_manager.h (right):

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
device/bluetooth/dbus/bluez_dbus_manager.h:13: #include
"chromeos/chromeos_export.h"
Use DEVICE_BLUETOOTH_EXPORT

[rkc, 2015-09-21 18:54:23]

Also changed all the dbus clients to use DEVICE_BLUETOOTH_EXPORT instead of
CHROMEOS_EXPORT.

https://codereview.chromium.org/1347193004/diff/1/chrome/browser/chromeos/chr...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

https://codereview.chromium.org/1347193004/diff/1/chrome/browser/chromeos/chr...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:174: // initialized.
On 2015/09/17 21:48:01, stevenjb wrote:
> See my other comments, but we should avoid this implicit dependency from the
get
> go.

Done.

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/BUILD.gn
File device/bluetooth/BUILD.gn (right):

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/BUILD.gn#n...
device/bluetooth/BUILD.gn:162: defines += [ "CHROMEOS_IMPLEMENTATION" ]
On 2015/09/17 21:48:01, stevenjb wrote:
> DEVICE_BLUETOOTH_IMPLEMENTATION

Done.

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/bluetooth.gyp
File device/bluetooth/bluetooth.gyp (right):

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/bluetooth....
device/bluetooth/bluetooth.gyp:134: 'CHROMEOS_IMPLEMENTATION',
On 2015/09/17 21:48:01, stevenjb wrote:
> DEVICE_BLUETOOTH_IMPLEMENTATION

Done.

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
File device/bluetooth/dbus/bluez_dbus_manager.cc (right):

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
device/bluetooth/dbus/bluez_dbus_manager.cc:10: #include
"chromeos/chromeos_switches.h"
On 2015/09/17 21:48:01, stevenjb wrote:
> Not needed

Done.

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
device/bluetooth/dbus/bluez_dbus_manager.cc:46: return
chromeos::DBusThreadManager::Get()->GetSystemBus();
On 2015/09/17 21:48:01, stevenjb wrote:
> Rather than depending on DBusThreadManager (which will only exist on
chromeos),
> pass dbus::Bus* to DBusThreadManager::Initialize(). I realize that this is a
> "not functional changes" CL, but I would rather skip adding the chromeos/
> dependency here entirely, and it's a pretty minor change.

Done.

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
device/bluetooth/dbus/bluez_dbus_manager.cc:134:
chromeos::DBusClientBundle::BLUETOOTH);
On 2015/09/17 21:48:01, stevenjb wrote:
> Pass |use_stub| here explicitly instead.

Done.

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
File device/bluetooth/dbus/bluez_dbus_manager.h (right):

https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
device/bluetooth/dbus/bluez_dbus_manager.h:13: #include
"chromeos/chromeos_export.h"
On 2015/09/17 21:48:01, stevenjb wrote:
> Use DEVICE_BLUETOOTH_EXPORT

Done.

[armansito, 2015-09-21 18:57:50]

On 2015/09/21 18:54:23, Rahul Chaturvedi wrote:
> Also changed all the dbus clients to use DEVICE_BLUETOOTH_EXPORT instead of
> CHROMEOS_EXPORT.
> 
>
https://codereview.chromium.org/1347193004/diff/1/chrome/browser/chromeos/chr...
> File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):
> 
>
https://codereview.chromium.org/1347193004/diff/1/chrome/browser/chromeos/chr...
> chrome/browser/chromeos/chrome_browser_main_chromeos.cc:174: // initialized.
> On 2015/09/17 21:48:01, stevenjb wrote:
> > See my other comments, but we should avoid this implicit dependency from the
> get
> > go.
> 
> Done.
> 
> https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/BUILD.gn
> File device/bluetooth/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/BUILD.gn#n...
> device/bluetooth/BUILD.gn:162: defines += [ "CHROMEOS_IMPLEMENTATION" ]
> On 2015/09/17 21:48:01, stevenjb wrote:
> > DEVICE_BLUETOOTH_IMPLEMENTATION
> 
> Done.
> 
>
https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/bluetooth.gyp
> File device/bluetooth/bluetooth.gyp (right):
> 
>
https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/bluetooth....
> device/bluetooth/bluetooth.gyp:134: 'CHROMEOS_IMPLEMENTATION',
> On 2015/09/17 21:48:01, stevenjb wrote:
> > DEVICE_BLUETOOTH_IMPLEMENTATION
> 
> Done.
> 
>
https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
> File device/bluetooth/dbus/bluez_dbus_manager.cc (right):
> 
>
https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
> device/bluetooth/dbus/bluez_dbus_manager.cc:10: #include
> "chromeos/chromeos_switches.h"
> On 2015/09/17 21:48:01, stevenjb wrote:
> > Not needed
> 
> Done.
> 
>
https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
> device/bluetooth/dbus/bluez_dbus_manager.cc:46: return
> chromeos::DBusThreadManager::Get()->GetSystemBus();
> On 2015/09/17 21:48:01, stevenjb wrote:
> > Rather than depending on DBusThreadManager (which will only exist on
> chromeos),
> > pass dbus::Bus* to DBusThreadManager::Initialize(). I realize that this is a
> > "not functional changes" CL, but I would rather skip adding the chromeos/
> > dependency here entirely, and it's a pretty minor change.
> 
> Done.
> 
>
https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
> device/bluetooth/dbus/bluez_dbus_manager.cc:134:
> chromeos::DBusClientBundle::BLUETOOTH);
> On 2015/09/17 21:48:01, stevenjb wrote:
> > Pass |use_stub| here explicitly instead.
> 
> Done.
> 
>
https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
> File device/bluetooth/dbus/bluez_dbus_manager.h (right):
> 
>
https://codereview.chromium.org/1347193004/diff/1/device/bluetooth/dbus/bluez...
> device/bluetooth/dbus/bluez_dbus_manager.h:13: #include
> "chromeos/chromeos_export.h"
> On 2015/09/17 21:48:01, stevenjb wrote:
> > Use DEVICE_BLUETOOTH_EXPORT
> 
> Done.

Was there a design doc for this change? A lot of people depend on this code;
what are we doing for regression testing here?

[rkc, 2015-09-21 19:01:44]

This code change isn't particularly complicated, it is just a lot of code. I can
whip up a quick design doc but I am not sure if it will contain much more
information than the CL descriptions will.

For regression testing I am depending on the automated tests that we have +
personal testing on the device. If there is anything else you can suggest, I'd
be happy to do it.

[rkc, 2015-09-21 19:45:26]

I've created a design doc explaining the plan. Please review.

http://go/chrome-bluetooth-linux

[stevenjb, 2015-09-21 20:38:53]

lgtm

https://codereview.chromium.org/1347193004/diff/10001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluez_dbus_manager.cc (right):

https://codereview.chromium.org/1347193004/diff/10001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluez_dbus_manager.cc:27: static BluezDBusManager*
g_bluez_dbus_manager = NULL;
nullptr (throughout)

[rkc, 2015-09-21 20:56:26]

https://codereview.chromium.org/1347193004/diff/10001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluez_dbus_manager.cc (right):

https://codereview.chromium.org/1347193004/diff/10001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluez_dbus_manager.cc:27: static BluezDBusManager*
g_bluez_dbus_manager = NULL;
On 2015/09/21 20:38:53, stevenjb wrote:
> nullptr (throughout)

Done.

[rkc, 2015-09-23 20:39:14]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 20:41:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1347193004/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1347193004/30001

[commit-bot: I haz the power, 2015-09-23 21:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 21:08:06]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[rkc, 2015-09-23 21:43:16]

rkc@chromium.org changed reviewers:
+ isherman@chromium.org

[rkc, 2015-09-23 21:43:17]

Adding isherman@chromium.org for
chrome/browser/metrics/chromeos_metrics_provider_unittest.cc

[rkc, 2015-09-23 21:44:38]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 21:47:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1347193004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1347193004/40001

[commit-bot: I haz the power, 2015-09-23 22:18:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 22:18:02]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Ilya Sherman, 2015-09-23 23:18:46]

https://codereview.chromium.org/1347193004/diff/40001/chrome/browser/metrics/...
File chrome/browser/metrics/chromeos_metrics_provider_unittest.cc (right):

https://codereview.chromium.org/1347193004/diff/40001/chrome/browser/metrics/...
chrome/browser/metrics/chromeos_metrics_provider_unittest.cc:35: using
chromeos::DBusThreadManagerSetter;
nit: Please re-alphabetize

https://codereview.chromium.org/1347193004/diff/40001/chrome/browser/metrics/...
chrome/browser/metrics/chromeos_metrics_provider_unittest.cc:87: // Set up the
fake Bluetooth environment,
nit: Remove this comment.

https://codereview.chromium.org/1347193004/diff/40001/chrome/browser/metrics/...
chrome/browser/metrics/chromeos_metrics_provider_unittest.cc:89:
DBusThreadManager::GetSetterForTesting();
nit: Move this line below the follow comment.

[armansito, 2015-09-24 18:39:45]

lgtm

[rkc, 2015-09-27 07:51:56]

https://codereview.chromium.org/1347193004/diff/40001/chrome/browser/metrics/...
File chrome/browser/metrics/chromeos_metrics_provider_unittest.cc (right):

https://codereview.chromium.org/1347193004/diff/40001/chrome/browser/metrics/...
chrome/browser/metrics/chromeos_metrics_provider_unittest.cc:35: using
chromeos::DBusThreadManagerSetter;
On 2015/09/23 23:18:46, Ilya Sherman wrote:
> nit: Please re-alphabetize

Done.

https://codereview.chromium.org/1347193004/diff/40001/chrome/browser/metrics/...
chrome/browser/metrics/chromeos_metrics_provider_unittest.cc:87: // Set up the
fake Bluetooth environment,
On 2015/09/23 23:18:46, Ilya Sherman wrote:
> nit: Remove this comment.

Done.

https://codereview.chromium.org/1347193004/diff/40001/chrome/browser/metrics/...
chrome/browser/metrics/chromeos_metrics_provider_unittest.cc:89:
DBusThreadManager::GetSetterForTesting();
On 2015/09/23 23:18:46, Ilya Sherman wrote:
> nit: Move this line below the follow comment.

Done.

[rkc, 2015-09-27 07:52:15]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-27 07:52:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1347193004/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1347193004/50001

[commit-bot: I haz the power, 2015-09-27 08:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-27 08:12:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rkc, 2015-09-27 17:54:03]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-27 17:54:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1347193004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1347193004/60001

[commit-bot: I haz the power, 2015-09-27 18:32:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-27 18:32:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ilya Sherman, 2015-09-28 01:56:55]

LGTM

[rkc, 2015-09-28 04:23:58]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-28 04:24:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1347193004/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1347193004/70001

[rkc, 2015-09-28 05:57:25]

rkc@chromium.org changed reviewers:
+ oshima@chromium.org

[rkc, 2015-09-28 05:57:26]

Adding oshima@ for ash/shell.cc owner's review.

[commit-bot: I haz the power, 2015-09-28 07:46:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 07:46:54]

Dry run: This issue passed the CQ dry run.

[oshima, 2015-09-28 17:34:12]

https://codereview.chromium.org/1347193004/diff/70001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/1347193004/diff/70001/ash/shell.cc#newcode864
ash/shell.cc:864: }
can you move this to AshTestHelper? That's where DBusThreadManager is
initialized.

[rkc, 2015-09-28 17:53:13]

https://codereview.chromium.org/1347193004/diff/70001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/1347193004/diff/70001/ash/shell.cc#newcode864
ash/shell.cc:864: }
On 2015/09/28 17:34:12, oshima wrote:
> can you move this to AshTestHelper? That's where DBusThreadManager is
> initialized.
> 

Done.

[oshima, 2015-09-28 18:25:20]

lgtm

[rkc, 2015-09-28 18:26:00]

The CQ bit was checked by rkc@chromium.org

[rkc, 2015-09-28 18:26:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, armansito@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1347193004/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-09-28 18:29:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1347193004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1347193004/80001

[commit-bot: I haz the power, 2015-09-28 19:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 19:29:22]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2015-09-28 20:35:46]

sky@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-09-28 20:35:47]

LGTM

[rkc, 2015-09-28 20:36:13]

The CQ bit was checked by rkc@chromium.org

[rkc, 2015-09-28 20:36:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, armansito@chromium.org, oshima@chromium.org,
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1347193004/#ps90001
(title: " ")

[commit-bot: I haz the power, 2015-09-28 20:39:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1347193004/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1347193004/90001

[commit-bot: I haz the power, 2015-09-28 21:09:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 21:09:23]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rkc, 2015-09-28 21:49:09]

The CQ bit was checked by rkc@chromium.org

[rkc, 2015-09-28 21:49:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, armansito@chromium.org, oshima@chromium.org,
stevenjb@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1347193004/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-09-28 21:52:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1347193004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1347193004/100001

[commit-bot: I haz the power, 2015-09-28 23:15:54]

Committed patchset #11 (id:100001)

[commit-bot: I haz the power, 2015-09-28 23:16:43]

Patchset 11 (id:??) landed as
https://crrev.com/5d3c8959a7aee861b6750fd734cad96bd24e1f9f
Cr-Commit-Position: refs/heads/master@{#351197}

[Lei Zhang, 2015-09-29 05:51:09]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-09-29 05:51:11]

This CL caused the following failures:

- ExtensionMessageBubbleTest failure on CrOS Valgrind
- Linux sizes failure due to new static initializers:
# fake_bluetooth_media_transport_client.cc
extensions::api::audio_modem::ReceivedToken::~ReceivedToken()
# fake_bluetooth_media_transport_client.cc
bluez::FakeBluetoothMediaTransportClient::kTransportConfiguration
# fake_bluetooth_media_transport_client.cc
bluez::FakeBluetoothMediaTransportClient::kTransportConfiguration+0x10
# fake_bluetooth_media_transport_client.cc
bluez::FakeBluetoothMediaTransportClient::kTransportConfiguration+0x8
# fake_bluetooth_media_transport_client.cc operator new(unsigned long)
# fake_bluetooth_media_transport_client.cc __cxa_atexit@plt [registers a dtor to
run at exit]
# fake_bluetooth_media_transport_client.cc __init_array_end+0x32f0

[Lei Zhang, 2015-09-29 05:53:33]

On 2015/09/29 05:51:11, Lei Zhang wrote:
> This CL caused the following failures:
> 
> - ExtensionMessageBubbleTest failure on CrOS Valgrind
> - Linux sizes failure due to new static initializers:
> # fake_bluetooth_media_transport_client.cc
> extensions::api::audio_modem::ReceivedToken::~ReceivedToken()
> # fake_bluetooth_media_transport_client.cc
> bluez::FakeBluetoothMediaTransportClient::kTransportConfiguration
> # fake_bluetooth_media_transport_client.cc
> bluez::FakeBluetoothMediaTransportClient::kTransportConfiguration+0x10
> # fake_bluetooth_media_transport_client.cc
> bluez::FakeBluetoothMediaTransportClient::kTransportConfiguration+0x8
> # fake_bluetooth_media_transport_client.cc operator new(unsigned long)
> # fake_bluetooth_media_transport_client.cc __cxa_atexit@plt [registers a dtor
to
> run at exit]
> # fake_bluetooth_media_transport_client.cc __init_array_end+0x32f0

Looking at the device/bluetooth/dbus/fake_bluetooth_media_transport_client.cc
change, I believe the static initializers existed previously, but went
undetected because there's no CrOS bot on the chromium portion of the main
waterfall.

[Lei Zhang, 2015-09-29 06:01:13]

On 2015/09/29 05:53:33, Lei Zhang wrote:
> Looking at the device/bluetooth/dbus/fake_bluetooth_media_transport_client.cc
> change, I believe the static initializers existed previously, but went
> undetected because there's no CrOS bot on the chromium portion of the main
> waterfall.

And I filed https://code.google.com/p/chromium/issues/detail?id=537081 for
adding a new CrOS bot.