Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1367663002: Add Linux support for the Bluetooth API. (Closed)

Created:
5 years, 3 months ago by rkc
Modified:
5 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, scheib+watch_chromium.org, extensions-reviews_chromium.org, jdeokule, kalq_chromium.org, scheib, stevenjb
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor_dbus
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Linux support for the Bluetooth API. This refactors all the code in //device/bluetooth to be non-ChromeOS specific and adds code to enable all of it to run on Linux through the linux specific DBusThreadManager that is added. This CL depends on https://codereview.chromium.org/1347193004/ Owners reviews requested, //device - armansito@ //extensions - rockot@ //chrome/browser/chrome_browser_main_linux.* - jhawkins@ R=armansito@chromium.org, jhawkins@chromium.org, rockot@chromium.org BUG=522633 Committed: https://crrev.com/17fcdab015a073437404f35e7e63c1464280d36b Cr-Commit-Position: refs/heads/master@{#351237}

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : merge #

Patch Set 4 : fixups #

Patch Set 5 : build fix #

Patch Set 6 : merge #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : gn fix #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1978 lines, -16621 lines) Patch
M chrome/browser/chrome_browser_main_linux.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 1 2 3 4 5 6 7 8 9 2 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M device/BUILD.gn View 1 2 3 4 5 6 7 8 9 2 chunks +15 lines, -9 lines 0 comments Download
M device/bluetooth/BUILD.gn View 1 2 3 4 5 6 7 8 9 7 chunks +32 lines, -32 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 2 3 4 5 6 7 8 9 7 chunks +32 lines, -28 lines 0 comments Download
M device/bluetooth/bluetooth_adapter.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
A + device/bluetooth/bluetooth_adapter_bluez.h View 1 2 3 4 5 6 7 8 9 14 chunks +49 lines, -50 lines 0 comments Download
A + device/bluetooth/bluetooth_adapter_bluez.cc View 1 2 3 4 5 6 7 8 9 63 chunks +292 lines, -312 lines 0 comments Download
D device/bluetooth/bluetooth_adapter_chromeos.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -404 lines 0 comments Download
D device/bluetooth/bluetooth_adapter_chromeos.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1515 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_factory.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_factory.cc View 1 2 3 4 5 6 7 8 9 4 chunks +10 lines, -3 lines 0 comments Download
A + device/bluetooth/bluetooth_adapter_profile_bluez.h View 1 2 3 4 5 6 7 8 9 6 chunks +16 lines, -16 lines 0 comments Download
A + device/bluetooth/bluetooth_adapter_profile_bluez.cc View 1 2 3 4 5 6 7 8 9 10 chunks +17 lines, -18 lines 0 comments Download
A + device/bluetooth/bluetooth_adapter_profile_bluez_unittest.cc View 1 2 3 4 5 6 7 8 9 16 chunks +53 lines, -59 lines 0 comments Download
D device/bluetooth/bluetooth_adapter_profile_chromeos.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -111 lines 0 comments Download
D device/bluetooth/bluetooth_adapter_profile_chromeos.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -161 lines 0 comments Download
D device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -388 lines 0 comments Download
A + device/bluetooth/bluetooth_advertisement_bluez.h View 1 2 3 4 5 6 7 8 9 3 chunks +13 lines, -13 lines 0 comments Download
A + device/bluetooth/bluetooth_advertisement_bluez.cc View 1 2 3 4 5 6 7 8 9 7 chunks +11 lines, -11 lines 0 comments Download
A + device/bluetooth/bluetooth_advertisement_bluez_unittest.cc View 1 2 3 4 5 6 7 8 9 11 chunks +17 lines, -19 lines 0 comments Download
D device/bluetooth/bluetooth_advertisement_chromeos.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -62 lines 0 comments Download
D device/bluetooth/bluetooth_advertisement_chromeos.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -139 lines 0 comments Download
D device/bluetooth/bluetooth_advertisement_chromeos_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -242 lines 0 comments Download
A + device/bluetooth/bluetooth_audio_sink_bluez.h View 1 2 3 4 5 6 7 8 9 8 chunks +15 lines, -15 lines 0 comments Download
A + device/bluetooth/bluetooth_audio_sink_bluez.cc View 1 2 3 4 5 6 7 8 9 25 chunks +61 lines, -66 lines 0 comments Download
A + device/bluetooth/bluetooth_audio_sink_bluez_unittest.cc View 1 2 3 4 5 6 7 8 9 33 chunks +80 lines, -95 lines 0 comments Download
D device/bluetooth/bluetooth_audio_sink_chromeos.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -222 lines 0 comments Download
D device/bluetooth/bluetooth_audio_sink_chromeos.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -575 lines 0 comments Download
D device/bluetooth/bluetooth_audio_sink_chromeos_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -958 lines 0 comments Download
A + device/bluetooth/bluetooth_bluez_unittest.cc View 1 2 3 4 5 6 7 8 9 165 chunks +268 lines, -305 lines 0 comments Download
D device/bluetooth/bluetooth_chromeos_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -4195 lines 0 comments Download
A + device/bluetooth/bluetooth_device_bluez.h View 1 2 3 4 5 6 7 8 9 8 chunks +21 lines, -23 lines 0 comments Download
A + device/bluetooth/bluetooth_device_bluez.cc View 1 2 3 4 5 6 7 8 9 31 chunks +134 lines, -136 lines 0 comments Download
D device/bluetooth/bluetooth_device_chromeos.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -207 lines 0 comments Download
D device/bluetooth/bluetooth_device_chromeos.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -734 lines 0 comments Download
M device/bluetooth/bluetooth_discovery_session_outcome.h View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -6 lines 0 comments Download
A + device/bluetooth/bluetooth_gatt_bluez_unittest.cc View 1 2 3 4 5 6 7 8 9 49 chunks +136 lines, -147 lines 0 comments Download
D device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1237 lines 0 comments Download
A + device/bluetooth/bluetooth_gatt_connection_bluez.h View 1 2 3 4 5 6 7 8 9 3 chunks +10 lines, -10 lines 0 comments Download
A + device/bluetooth/bluetooth_gatt_connection_bluez.cc View 1 2 3 4 5 6 7 8 9 7 chunks +9 lines, -9 lines 0 comments Download
D device/bluetooth/bluetooth_gatt_connection_chromeos.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -58 lines 0 comments Download
D device/bluetooth/bluetooth_gatt_connection_chromeos.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -105 lines 0 comments Download
A + device/bluetooth/bluetooth_gatt_notify_session_bluez.h View 1 2 3 4 5 6 7 8 9 4 chunks +12 lines, -12 lines 0 comments Download
A + device/bluetooth/bluetooth_gatt_notify_session_bluez.cc View 1 2 3 4 5 6 7 8 9 7 chunks +13 lines, -13 lines 0 comments Download
D device/bluetooth/bluetooth_gatt_notify_session_chromeos.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -77 lines 0 comments Download
D device/bluetooth/bluetooth_gatt_notify_session_chromeos.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -134 lines 0 comments Download
A + device/bluetooth/bluetooth_pairing_bluez.h View 1 2 3 4 5 6 7 8 9 4 chunks +17 lines, -17 lines 0 comments Download
A + device/bluetooth/bluetooth_pairing_bluez.cc View 1 2 3 4 5 6 7 8 9 14 chunks +29 lines, -33 lines 0 comments Download
D device/bluetooth/bluetooth_pairing_chromeos.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -148 lines 0 comments Download
D device/bluetooth/bluetooth_pairing_chromeos.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -276 lines 0 comments Download
A + device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h View 1 2 3 4 5 6 7 8 9 5 chunks +17 lines, -17 lines 0 comments Download
A + device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.cc View 1 2 3 4 5 6 7 8 9 26 chunks +64 lines, -76 lines 0 comments Download
D device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -150 lines 0 comments Download
D device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -487 lines 0 comments Download
A + device/bluetooth/bluetooth_remote_gatt_descriptor_bluez.h View 1 2 3 4 5 6 7 8 9 4 chunks +15 lines, -15 lines 0 comments Download
A + device/bluetooth/bluetooth_remote_gatt_descriptor_bluez.cc View 1 2 3 4 5 6 7 8 9 6 chunks +25 lines, -28 lines 0 comments Download
D device/bluetooth/bluetooth_remote_gatt_descriptor_chromeos.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -78 lines 0 comments Download
D device/bluetooth/bluetooth_remote_gatt_descriptor_chromeos.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -126 lines 0 comments Download
A + device/bluetooth/bluetooth_remote_gatt_service_bluez.h View 1 2 3 4 5 6 7 8 9 5 chunks +29 lines, -29 lines 0 comments Download
A + device/bluetooth/bluetooth_remote_gatt_service_bluez.cc View 1 2 3 4 5 6 7 8 9 19 chunks +40 lines, -41 lines 0 comments Download
D device/bluetooth/bluetooth_remote_gatt_service_chromeos.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -148 lines 0 comments Download
D device/bluetooth/bluetooth_remote_gatt_service_chromeos.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -339 lines 0 comments Download
A + device/bluetooth/bluetooth_socket_bluez.h View 1 2 3 4 5 6 7 8 9 7 chunks +21 lines, -24 lines 0 comments Download
A + device/bluetooth/bluetooth_socket_bluez.cc View 1 2 3 4 5 6 7 8 9 27 chunks +81 lines, -96 lines 0 comments Download
A + device/bluetooth/bluetooth_socket_bluez_unittest.cc View 1 2 3 4 5 6 7 8 9 28 chunks +66 lines, -75 lines 0 comments Download
D device/bluetooth/bluetooth_socket_chromeos.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -203 lines 0 comments Download
D device/bluetooth/bluetooth_socket_chromeos.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -559 lines 0 comments Download
D device/bluetooth/bluetooth_socket_chromeos_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -634 lines 0 comments Download
M device/bluetooth/bluetooth_socket_thread.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_agent_service_provider.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_dbus_client_bundle.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_descriptor_client.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_manager_client.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_service_client.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_service_service_provider.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_media_endpoint_service_provider.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_profile_service_provider.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/dbus/bluez_dbus_manager.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
A device/bluetooth/dbus/dbus_thread_manager_linux.h View 1 2 3 4 5 6 7 8 9 1 chunk +59 lines, -0 lines 0 comments Download
A device/bluetooth/dbus/dbus_thread_manager_linux.cc View 1 2 3 4 5 6 7 8 9 1 chunk +72 lines, -0 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_adapter_client.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_agent_manager_client.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_agent_service_provider.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_client.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_service_provider.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_manager_client.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_service_client.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_service_service_provider.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_input_client.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_le_advertisement_service_provider.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_le_advertising_manager_client.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_client.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_endpoint_service_provider.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_transport_client.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_profile_manager_client.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_profile_service_provider.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_adapter.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/test/mock_bluetooth_adapter.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/test/mock_bluetooth_advertisement.h View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_advertisement.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/device_tests.gyp View 1 2 3 4 5 6 7 8 9 2 chunks +14 lines, -8 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_event_router.cc View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 43 (17 generated)
rkc
5 years, 3 months ago (2015-09-23 20:07:17 UTC) #1
Ken Rockot(use gerrit already)
https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json File extensions/common/api/_manifest_features.json (right): https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json#newcode77 extensions/common/api/_manifest_features.json:77: "channel": "trunk", Is this really what you want to ...
5 years, 3 months ago (2015-09-23 20:12:53 UTC) #2
jdeokule
https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json File extensions/common/api/_manifest_features.json (right): https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json#newcode77 extensions/common/api/_manifest_features.json:77: "channel": "trunk", On 2015/09/23 20:12:53, Ken Rockot wrote: > ...
5 years, 3 months ago (2015-09-23 20:22:52 UTC) #4
rkc
https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json File extensions/common/api/_manifest_features.json (right): https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json#newcode77 extensions/common/api/_manifest_features.json:77: "channel": "trunk", On 2015/09/23 20:22:52, jdeokule wrote: > On ...
5 years, 3 months ago (2015-09-23 20:26:42 UTC) #5
Ken Rockot(use gerrit already)
https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json File extensions/common/api/_manifest_features.json (right): https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json#newcode77 extensions/common/api/_manifest_features.json:77: "channel": "trunk", On 2015/09/23 20:22:52, jdeokule wrote: > On ...
5 years, 3 months ago (2015-09-23 20:27:21 UTC) #6
Ken Rockot(use gerrit already)
On 2015/09/23 20:27:21, Ken Rockot wrote: > https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json > File extensions/common/api/_manifest_features.json (right): > > https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json#newcode77 ...
5 years, 3 months ago (2015-09-23 20:28:24 UTC) #7
Ken Rockot(use gerrit already)
On 2015/09/23 20:26:42, Rahul Chaturvedi wrote: > https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json > File extensions/common/api/_manifest_features.json (right): > > https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json#newcode77 ...
5 years, 3 months ago (2015-09-23 20:29:22 UTC) #8
rkc
https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json File extensions/common/api/_manifest_features.json (right): https://codereview.chromium.org/1367663002/diff/1/extensions/common/api/_manifest_features.json#newcode77 extensions/common/api/_manifest_features.json:77: "channel": "trunk", On 2015/09/23 20:27:21, Ken Rockot wrote: > ...
5 years, 3 months ago (2015-09-23 20:32:34 UTC) #9
Ken Rockot(use gerrit already)
extensions lgtm
5 years, 3 months ago (2015-09-23 20:34:15 UTC) #10
armansito
lgtm. Added scheib@ as FYI
5 years, 3 months ago (2015-09-24 18:42:10 UTC) #12
James Hawkins
lgtm
5 years, 2 months ago (2015-09-25 16:04:32 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367663002/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367663002/30001
5 years, 2 months ago (2015-09-28 06:23:09 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/37353) chromeos_x86-generic_chromium_compile_only_ng on ...
5 years, 2 months ago (2015-09-28 06:44:49 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367663002/40001
5 years, 2 months ago (2015-09-28 16:05:57 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/120744) chromeos_daisy_chromium_compile_only_ng on ...
5 years, 2 months ago (2015-09-28 16:12:43 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367663002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367663002/50001
5 years, 2 months ago (2015-09-28 17:11:53 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/119293)
5 years, 2 months ago (2015-09-28 17:37:16 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367663002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367663002/60001
5 years, 2 months ago (2015-09-28 18:24:41 UTC) #27
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/119350)
5 years, 2 months ago (2015-09-28 19:02:26 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367663002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367663002/70001
5 years, 2 months ago (2015-09-28 21:55:11 UTC) #31
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/119519)
5 years, 2 months ago (2015-09-28 22:25:16 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367663002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367663002/80001
5 years, 2 months ago (2015-09-28 23:03:57 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/104489)
5 years, 2 months ago (2015-09-28 23:19:36 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367663002/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367663002/90001
5 years, 2 months ago (2015-09-29 00:50:41 UTC) #41
commit-bot: I haz the power
Committed patchset #10 (id:90001)
5 years, 2 months ago (2015-09-29 02:24:22 UTC) #42
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 02:25:48 UTC) #43
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/17fcdab015a073437404f35e7e63c1464280d36b
Cr-Commit-Position: refs/heads/master@{#351237}

Powered by Google App Engine
This is Rietveld 408576698